This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Merged
Conversation
|
Congratulations Mik317 - your fix has been selected! 🎉 Thanks for being part of the community & helping secure the world's open source code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounty URL: https://www.huntr.dev/bounties/1-npm-openframe-image
⚙️ Description *
The
openframe-imagemodule was vulnerable againstMITMand similar attacks since someresourceswere downloaded using aHTTPconnection💻 Technical Description *
I just changed the
httplinks tohttps(certificates are OK ongithub.com👍 )🐛 Proof of Concept (PoC) *
Not needed
🔥 Proof of Fix (PoF) *
Using
wiresharkyou're no more able to see the content of thedownloadedfiles👍 User Acceptance Testing (UAT)
All ok 👍