Skip to content

feat: set favorite bookmark#126

Merged
chanhihi merged 3 commits intodevelopfrom
dev/109-feat-add-favorite-setting/#109
Mar 28, 2024
Merged

feat: set favorite bookmark#126
chanhihi merged 3 commits intodevelopfrom
dev/109-feat-add-favorite-setting/#109

Conversation

@JH713
Copy link
Collaborator

@JH713 JH713 commented Mar 26, 2024

📌 개요

  • 즐겨찾기 설정

💻 작업 내용

  • 즐겨찾기 북마크 id를 UserDefaults에 저장
  • 스와이프에서 즐겨찾기 설정
  • 즐겨찾기 설정/삭제 시 favorite webview reload

🖼️ 스크린샷

Simulator Screen Recording - iPhone 15 Pro - 2024-03-26 at 21 00 53

@JH713 JH713 linked an issue Mar 26, 2024 that may be closed by this pull request
@noeyiz
Copy link
Collaborator

noeyiz commented Mar 28, 2024

  • 즐겨찾기 기본값은 42 인트라
  • UserDefaults에 Bookmark를 다 저장하지 않고 UUID 저장하도록 변경

즐겨찾기 기능 구현하신 것 확인했습니다 ! 고생하셨습니다 👍🏻

Copy link
Member

@chanhihi chanhihi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chanhihi chanhihi merged commit 826f051 into develop Mar 28, 2024
@JH713 JH713 self-assigned this Apr 1, 2024
@chanhihi chanhihi deleted the dev/109-feat-add-favorite-setting/#109 branch April 4, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add favorite setting

3 participants