Skip to content

fix: ShareExtension의 로직+Context 변경 /#182#192

Merged
JH713 merged 15 commits intodevelopfrom
dev/fix-shareextension의-로직-변경/#182
Apr 16, 2024

Hidden character warning

The head ref may contain hidden characters: "dev/fix-shareextension\uc758-\ub85c\uc9c1-\ubcc0\uacbd/#182"
Merged

fix: ShareExtension의 로직+Context 변경 /#182#192
JH713 merged 15 commits intodevelopfrom
dev/fix-shareextension의-로직-변경/#182

Conversation

@chanhihi
Copy link
Member

@chanhihi chanhihi commented Apr 16, 2024

📌 개요

  • ShareExtension의 로직을 변경합니다.
  • ShareExtension의 UI를 변경합니다.

💻 작업 내용

  • UI 변경
  • ShareExtension에서 SwiftSoup를 메인앱에서 사용합니다.
  • 현재 data 통신시 title, url을 구독하여 변경시 적용이 되도록 사용합니다.
  • 변경점이 굉장히 늦게 뜰 수 있는 현상을 발견하여, 성능 최적화 혹은 스켈레톤 UI등 필요합니다.

🖼️ 스크린샷

image Simulator Screen Recording - iPhone 15 - 2024-04-16 at 17 27 54

@chanhihi chanhihi linked an issue Apr 16, 2024 that may be closed by this pull request
@chanhihi chanhihi self-assigned this Apr 16, 2024
@chanhihi chanhihi added the ✨ Enhancement New feature or request label Apr 16, 2024
Copy link
Collaborator

@noeyiz noeyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI 바뀐 것 굳이네용

@chanhihi chanhihi changed the title Dev/fix shareextension의 로직 변경/#182 fix: ShareExtension의 로직+Context 변경 /#182 Apr 16, 2024
@chanhihi chanhihi marked this pull request as ready for review April 16, 2024 08:30
@JH713 JH713 merged commit 990499e into develop Apr 16, 2024
@chanhihi chanhihi deleted the dev/fix-shareextension의-로직-변경/#182 branch April 18, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: ShareExtension의 로직 변경

3 participants