Skip to content

feat: loading 중 skeletonview#226

Merged
chanhihi merged 5 commits intodevelopfrom
dev/223-feat-불러오는-동안-skeletonview/#223
Apr 22, 2024

Hidden character warning

The head ref may contain hidden characters: "dev/223-feat-\ubd88\ub7ec\uc624\ub294-\ub3d9\uc548-skeletonview/#223"
Merged

feat: loading 중 skeletonview#226
chanhihi merged 5 commits intodevelopfrom
dev/223-feat-불러오는-동안-skeletonview/#223

Conversation

@JH713
Copy link
Collaborator

@JH713 JH713 commented Apr 21, 2024

📌 개요

  • 쉐어익스텐션/북마크 추가에서 url fetching 중 skeletonView 추가

💻 작업 내용

  • 해당 textview에 skeletonable 추가
  • fetching 여부 알려주는 isFetching 변수 추가
  • fetching 중 오류 시 alert

🖼️ 스크린샷

성공 실패
success Simulator Screen Recording - iPhone 15 Pro - 2024-04-21 at 22 15 23

@JH713 JH713 linked an issue Apr 21, 2024 that may be closed by this pull request
@JH713 JH713 self-assigned this Apr 21, 2024
@JH713 JH713 added the ✨ Enhancement New feature or request label Apr 21, 2024
Copy link
Member

@chanhihi chanhihi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스켈레톤 UI 확인했습니다. 고생하셨습니다!

@noeyiz
Copy link
Collaborator

noeyiz commented Apr 22, 2024

짱멋져 ~

@jonnwon
Copy link
Collaborator

jonnwon commented Apr 22, 2024

넘 멋있어요!

@chanhihi chanhihi merged commit 35260a3 into develop Apr 22, 2024
@chanhihi chanhihi deleted the dev/223-feat-불러오는-동안-skeletonview/#223 branch April 22, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: 불러오는 동안 SkeletonView

4 participants