Skip to content

fix: web view 안에서 새 창 이동 안되는 경우 처리 #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonnwon merged 2 commits into from
Apr 29, 2024
Merged

fix: web view 안에서 새 창 이동 안되는 경우 처리 #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02c2f17
docs: .gitignore 수정
JH713 Apr 26, 2024
be31900
fix: web View 안에서 새 창 이동하는 경우 처리
JH713 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,5 @@ Derived/

### Tuist managed dependencies ###
Tuist/Dependencies

.mise.toml
10 changes: 10 additions & 0 deletions iBox/Sources/Web/WebView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ class WebView: UIView {
private func setupProperty() {
backgroundColor = .backgroundColor
webView.navigationDelegate = self
webView.uiDelegate = self
progressObserver = webView.observe(\.estimatedProgress, options: .new) { [weak self] webView, _ in
self?.progressView.setProgress(Float(webView.estimatedProgress), animated: true)
}
Expand Down Expand Up @@ -221,3 +222,12 @@ extension WebView: UIGestureRecognizerDelegate {
}

}

extension WebView: WKUIDelegate {
func webView(_ webView: WKWebView, createWebViewWith configuration: WKWebViewConfiguration, for navigationAction: WKNavigationAction, windowFeatures: WKWindowFeatures) -> WKWebView? {
if navigationAction.targetFrame == nil {
webView.load(navigationAction.request)
}
return nil
}
}