Skip to content

fix: 아이패드 대응 UIActivityViewController popover 설정 #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chanhihi merged 1 commit into from
May 3, 2024
Merged

fix: 아이패드 대응 UIActivityViewController popover 설정 #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions iBox/Sources/BoxList/BoxListView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,10 +448,7 @@ extension BoxListView: UITableViewDelegate {
generator.impactOccurred()
}

let activityViewController = UIActivityViewController(activityItems: [url], applicationActivities: nil)
if let viewController = self.delegate as? UIViewController {
viewController.present(activityViewController, animated: true, completion: nil)
}
delegate?.pushViewController(url: url)
}

let editAction = UIAction(title: "북마크 편집", image: UIImage(systemName: "pencil")) { [weak self] action in
Expand All @@ -475,8 +472,6 @@ extension BoxListView: UITableViewDelegate {
}
}



return UIMenu(title: "", children: [favoriteAction, shareAction, editAction, deleteAction])
}
}
Expand Down
8 changes: 8 additions & 0 deletions iBox/Sources/BoxList/BoxListViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,14 @@ extension BoxListViewController: BoxListViewDelegate {
func pushViewController(url: URL?) {
guard let url = url else { return }
let activityViewController = UIActivityViewController(activityItems: [url], applicationActivities: nil)

// 아이패드 대응
if let popoverController = activityViewController.popoverPresentationController {
popoverController.sourceView = self.view
popoverController.sourceRect = CGRect(x: self.view.bounds.midX, y: self.view.bounds.midY, width: 0, height: 0)
popoverController.permittedArrowDirections = []
}

self.present(activityViewController, animated: true)
}

Expand Down