Skip to content

Allow to configure ALLOW_NO_DEVICE (nee NUT_NOCONF_ALLOWED) option via upsd.conf#109

Merged
jimklimov merged 6 commits into42ity:FTYfrom
jimklimov:upsd-no-conf-filetoo
Apr 21, 2020
Merged

Allow to configure ALLOW_NO_DEVICE (nee NUT_NOCONF_ALLOWED) option via upsd.conf#109
jimklimov merged 6 commits into42ity:FTYfrom
jimklimov:upsd-no-conf-filetoo

Conversation

@jimklimov
Copy link
Copy Markdown
Member

Follow-up from #102

Tested to support different ways of spelling the boolean setting in upsd.conf and in envvar as supported (and with higher priority) per original PR.

Copy link
Copy Markdown

@boricj boricj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I'll bike-shed the name of the configuration key. This is the only configuration key with underscores and the only prefixed by NUT_.

I won't demand a change, but do consider making things consistent.

@jimklimov
Copy link
Copy Markdown
Member Author

I agree, that concerned me too. The name originally came to be like the other envvars recognized by the code (and "namespaced" into NUT_). I suppose if Arno has no comments on this soon, we can merge this as is for 42ity and later solve "properly" with equivalent PR in upstream NUT.

For 42ity use-case, currently this setting is easier to propagate via envvars of nut.conf as (and/or because) it is already done in earlier PR. So a renaming change coming back from upstream (or a next commit here) to the upsd.conf option name will not hurt anything :)

@aquette
Copy link
Copy Markdown
Member

aquette commented Apr 21, 2020

@jimklimov ack, letting pass for now. But please remember me / other (ticket) later that we have a tech debt to fix. Will try to PoC... later when I got time and WR20 is out and cooling stage 1 is delivered.
waiting for the green light, but approving for you to merge and not lagging after me ;)

@jimklimov jimklimov force-pushed the upsd-no-conf-filetoo branch from ffe5184 to cbf1adc Compare April 21, 2020 10:33
@jimklimov jimklimov changed the title Allow to configure NUT_NOCONF_ALLOWED option via upsd.conf Allow to configure ALLOW_NO_DEVICE (nee NUT_NOCONF_ALLOWED) option via upsd.conf Apr 21, 2020
@jimklimov jimklimov merged commit cf14d8e into 42ity:FTY Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants