[DO NOT MERGE] Reference: https://github.com/networkupstools/nut/pull/473#39
Closed
geraldguillaume wants to merge 1 commit into42ity:FTYfrom
Closed
[DO NOT MERGE] Reference: https://github.com/networkupstools/nut/pull/473#39geraldguillaume wants to merge 1 commit into42ity:FTYfrom
geraldguillaume wants to merge 1 commit into42ity:FTYfrom
Conversation
Signed-off-by: Gerald Guillaume <geraldguillaume@eaton.com>
Member
|
That is an unconventional way of applying commits made (signed, dated) by others ;) Usually one adds the remote repo and cherry-picks stuff. When this lands into upstream and back to our fork, there will be less/no merge conflicts to solve. Otherwise LGTM. |
aquette
changed the title
Member
|
@jimklimov is right, even more considering the full-duplex synchro that needs to be done between upstream nut and fty version. |
Member
|
Discarded by #40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fty-discovery needs and uses successfully this fix provided by @jimklimov, thanks to him.
This fix allow fty-discovery to do straightforward exec "/lib/nut/snmp-ups -s dumpdataXXX" and manage successfully timeout (signal SIGTERM/SIGKILL).
Signed-off-by: Gerald Guillaume geraldguillaume@eaton.com