Skip to content

upsd should return EXIT_FAILURE when -c failed#64

Merged
jimklimov merged 1 commit intoFTYfrom
upsd-reload-fix
Sep 19, 2018
Merged

upsd should return EXIT_FAILURE when -c failed#64
jimklimov merged 1 commit intoFTYfrom
upsd-reload-fix

Conversation

@aquette
Copy link
Copy Markdown
Member

@aquette aquette commented Sep 19, 2018

Signed-off-by: Arnaud Quette ArnaudQuette@Eaton.com

Signed-off-by: Arnaud Quette <ArnaudQuette@Eaton.com>
@jimklimov
Copy link
Copy Markdown
Member

Note: makes sense to backport it to upstream NUT as well, and then I'd add an upsdebugx(1,... or even louder a printed message if there was an error sending the signal (e.g. process not running, signal not permitted (user to root), etc.) maybe complete with an errno or whatever detail can be gleaned.

@jimklimov jimklimov merged commit d6709e0 into FTY Sep 19, 2018
@jimklimov
Copy link
Copy Markdown
Member

jimklimov commented Sep 19, 2018

Upon further review, logging is not needed - the errors are reported visibly already by sendsignalfn() in common/common.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants