Improve add-db-to-osd.sh #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkelly16
reviewed
Apr 15, 2025
anthonyeleven
force-pushed
the
improve-add-db-to-osd.sh
branch
from
bac099a to
f657006
Compare
bkelly16
requested changes
Apr 15, 2025
Member
bkelly16
left a comment
bkelly16
left a comment
There was a problem hiding this comment.
Thanks for the feedback Anthony
add-db-to-osd.sh
Outdated
| OSD_PER_DB_LIMIT=5 | ||
|
|
||
| while getopts 'b:fo:d:h' OPTION; do | ||
| while getopts 'b:fo:d:h:r' OPTION; do |
Member
There was a problem hiding this comment.
":" needs to trail the r here, not precede
Contributor
Author
There was a problem hiding this comment.
Ah, haven't used getopts much and was confused re the subtleties. Pushed an ammendment
add-db-to-osd.sh
Outdated
| ceph osd set noout | ||
| echo "Stop OSD.$OSD_ID" | ||
| systemctl stop ceph-osd@$OSD_ID | ||
| # Is this a relic of Filestore and thus superfluous? |
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
anthonyeleven
force-pushed
the
improve-add-db-to-osd.sh
branch
from
f657006 to
3187d58
Compare
Member
|
lgtm, merging (sorry for taking so long hahahaha) |
Contributor
Author
|
No problem, good sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve spelling and caps, add the ability to specify the number of offload slices per device, add an ok-to-stop check.