This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Enhance the TextField component#156
Merged
DiogoSoaress merged 7 commits intodevelopmentfrom Oct 8, 2021
Merged
Conversation
katspaugh
reviewed
Oct 4, 2021
src/inputs/TextField/index.tsx
Outdated
| return { | ||
| value: props.value, | ||
| onChange: props.onChange, | ||
| }; |
Member
There was a problem hiding this comment.
As a quick feedback, it seems like you suggest to support two sets of incompatible props on the same component.
Would it maybe make sense to expose two different components then?
Contributor
There was a problem hiding this comment.
It's a pretty common pattern in TypeScript 🤷♂️ It's like you do string | number, but a little bit more complex
Use of conditional props to receive an input and use its own onChange instead of a onChange handler passed in the props. Co-authored-by: Aaron Cook <iamacook@users.noreply.github.com>
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Co-authored-by: DiogoSoaress <DiogoSoaress@users.noreply.github.com>
Contributor
|
After discussing the props with @mikheevm, @DiogoSoaress and I came up with the above, standardised |
9 tasks
mmv08
reviewed
Oct 7, 2021
src/inputs/TextField/index.tsx
Outdated
| value={value} | ||
| color="primary" | ||
| onChange={onChange} | ||
| readOnly |
mmv08
approved these changes
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.