Add adress info Component by alongoni · Pull Request #26 · 5afe/safe-react-components

+const EllipsisMenu = ({ menuItems }: Props): React.ReactElement => {
+  const [anchorEl, setAnchorEl] = React.useState(null);
+
+  const handleClick = (event: any) => setAnchorEl(event.currentTarget);


I could not add the type, perhaps someone could help me with it.

something around...

const handleClick: React.MouseEventHandler<'onclick'> = (event) => setAnchor(event.currentTarget);

seems to work.

Probably too specific, but in this case, I think it's enough.

it does not work for me

Material UI docs have both JS/TS examples with types 😉

I know and I already test it. But didn't work.

Could you try yourself? Perhaps it's a problem with my computer.

If you read through error message it says that it cannot assign to type of null (which is the inferred type of anchorEl). I already pushed a fix

nicosampler · 2020-07-28T13:49:38Z

once CopyToClipboardBtn component is merged, I have to replace the fixed icon "copy" by the component.

ghost · 2020-07-28T17:33:09Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

ghost · 2020-07-28T17:45:53Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

ghost · 2020-07-29T08:12:00Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

mmv08 · 2020-07-29T10:14:03Z

src/ethereum/AddressInfo/addressinfo.stories.tsx

+  <AddressInfo address={address} shortenAddress={4} />
+);
+
+export const WithOwner = (): React.ReactElement => (


WIth a name, not necessarily an owner

mmv08 · 2020-07-29T10:14:18Z

src/ethereum/AddressInfo/addressinfo.stories.tsx

+    address={address}
+    name="Owner 1"
+    showIdenticon
+    showCopy


showCopyWhat?

mmv08 · 2020-07-29T10:14:30Z

src/ethereum/AddressInfo/addressinfo.stories.tsx

+    name="Owner 1"
+    showIdenticon
+    showCopy
+    showEtherscan


showEtherscanWhat?

mmv08 · 2020-07-29T10:15:39Z

src/ethereum/AddressInfo/index.tsx

+  showEtherscan?: boolean;
+};
+
+const getShortAddress = (text: string, shortenAddress: number) =>


I think this wrapper over wrapper is unnecessary, you could use textShortener just fine

mmv08 · 2020-07-29T10:17:45Z

src/navigation/EllipsisMenu/index.stories.tsx

+  { label: 'Item 2', onClick: console.log },
+];
+
+export const Loader = (): React.ReactElement => (


Why is this called Loader?

mmv08 · 2020-07-29T10:18:04Z

src/navigation/EllipsisMenu/index.tsx

+  :focus {
+    outline: none;
+  }


http://www.outlinenone.com/

src/navigation/EllipsisMenu/index.tsx

… into adress-info

ghost · 2020-07-29T13:40:48Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

ghost · 2020-07-29T13:41:20Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

ghost · 2020-07-29T14:03:10Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

fernandomg · 2020-07-29T14:33:12Z

shouldn't this be closing #23 instead of #40?

@alongoni, @nicosampler

ghost · 2020-07-29T14:42:06Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

ghost · 2020-07-29T16:27:52Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

ghost · 2020-07-29T16:52:06Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

ghost · 2020-07-29T19:22:34Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

ghost · 2020-07-29T19:29:54Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

mmv08

Please fix those before merging

mmv08 · 2020-07-30T10:31:28Z

src/inputs/ButtonLink/index.tsx

@@ -29,12 +30,13 @@ const StyledButtonLink = styled.button<Props>`
 const ButtonLik = ({


mmv08 · 2020-07-30T10:32:19Z

src/navigation/EllipsisMenu/index.tsx

+          keepMounted
+          onClose={closeMenuHandler}
+          open={Boolean(anchorEl)}>
+          {menuItems.map((item, i) => (


i is unused

ghost · 2020-07-30T11:57:35Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

ghost · 2020-07-30T13:35:26Z

Travis automatic deployment:
https://pr26--safereactcomponents.review.gnosisdev.com

Add adress info Component

4e9a79a

alongoni self-assigned this Jun 26, 2020

improve texts aligment

bb0a455

add flex property

a59f1b7

nicosampler self-assigned this Jul 17, 2020

Merge branch 'development' into adress-info

6e05f00

add functionality

d1f86ad

Fer suggestion

6095645

nicosampler requested review from Agupane, dasanra, fernandomg and mmv08 July 28, 2020 13:24

nicosampler marked this pull request as ready for review July 28, 2020 13:25

nicosampler reviewed Jul 28, 2020

View reviewed changes

remove harcoded string

092babc

add className

4db5a8f

ButtonLink: Adding textSize

0cf383e

mmv08 suggested changes Jul 29, 2020

View reviewed changes

type fixes, minor dep updates

3577b05

nicosampler added 4 commits July 29, 2020 10:34

review changes

8b1ae8d

Merge branch 'adress-info' of github.com:gnosis/safe-react-components…

b672360

… into adress-info

Merge branch 'development' into adress-info

71bc496

rename function

07dbffd

Adding copy functionality

03db3be

bring back outline

fa71a3e

Identicon: add xs size

dde7157

nicosampler added 2 commits July 29, 2020 13:46

Theme: Add warning color

d9fd15c

AddressInfo: Add text size and color

e68716c

nicosampler added 3 commits July 29, 2020 16:16

Icon: Fix z-index for tooltip

b4100af

AddressInfo: Icons alignment

1bfdae1

CopyToClipboardBtn: CopyBtn outline color

d78fae7

AddressInfo: Add network props

35cdf92

mmv08 approved these changes Jul 30, 2020

View reviewed changes

Review changes

d820297

fix linter

ae0f56d

nicosampler merged commit 2b4635b into development Jul 30, 2020

nicosampler deleted the adress-info branch July 30, 2020 13:36

nicosampler mentioned this pull request Sep 15, 2020

safe-react-components v0.3.0 #67

Merged

		@@ -29,12 +30,13 @@ const StyledButtonLink = styled.button<Props>`
		const ButtonLik = ({

Conversation

alongoni commented Jun 26, 2020 • edited by nicosampler Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 26, 2020

Uh oh!

ghost commented Jun 26, 2020

Uh oh!

ghost commented Jun 26, 2020

Uh oh!

github-actions bot commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

Uh oh!

ghost commented Jul 27, 2020

Uh oh!

ghost commented Jul 27, 2020

Uh oh!

ghost commented Jul 28, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicosampler Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicosampler commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 28, 2020

Uh oh!

ghost commented Jul 28, 2020

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

fernandomg commented Jul 29, 2020

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

mmv08 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alongoni commented Jun 26, 2020 •

edited by nicosampler

Loading

github-actions bot commented Jul 27, 2020 •

edited

Loading

nicosampler Jul 28, 2020 •

edited

Loading

nicosampler commented Jul 28, 2020 •

edited

Loading