Storybook won't start without file-loader dependency installed

[alfetopito]

Trying to run yarn storybook from a fresh development branch install fails:

After adding missing dependency it works

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr56--safereactcomponents.review.gnosisdev.com

[fernandomg]

@alfetopito, thanks!

I'm not sure if adding a dependency of a dependency is the solution, tho.

Funny thing, I fixed the same issue with a different approach: by downgrading webpack to the previous version. https://github.com/gnosis/safe-react-components/pull/55/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R69

... and now I see there's a 0.44.1 that may fix this seamlessly.

Edit: no, it didn't worked

[alfetopito]

@alfetopito, thanks!

I'm not sure if adding a dependency of a dependency is the solution, tho.

I'm not sure it qualifies as a dependency of a dependency.
It's used directly on https://github.com/gnosis/safe-react-components/blob/b83b411442aefba7b8335baa247bb9dbc872a9ec/webpack.config.js#L22 as well as the storybook webpack config https://github.com/gnosis/safe-react-components/blob/b83b411442aefba7b8335baa247bb9dbc872a9ec/.storybook/webpack.config.js#L18

Funny thing, I fixed the same issue with a different approach: by downgrading webpack to the previous version. https://github.com/gnosis/safe-react-components/pull/55/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R69

... and now I see there's a 0.44.1 that may fix this seamlessly.

Edit: no, it didn't worked

Now if you say this should come bundled with Webpack, then I agree.
But is it?

For example, dex-react also sets it as a dev dependency https://github.com/gnosis/dex-react/search?q=file-loader&unscoped_q=file-loader

[mmv08]

If you inspect yarn.lock it seems that we have two file-loader installed, one is a dependency of storybook core and one is the one we explicitly add as a dep. Looks like it was working previously because of that storybook dependency. I think it's good to include it in our dependencies list if we depend on it.

[alfetopito]

I'm not familiar with your team's dev practices, I can leave it up to you to merge it.

Otherwise I can do it if you don't mind and tell me which I should pick:

That is, if one approval is enough.

[mmv08]

@alfetopito usually we squash to dev and a regular merge to master