Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Added Tooltip component and stories#61

Closed
alfetopito wants to merge 1 commit intodevelopmentfrom
tooltip-component
Closed

Added Tooltip component and stories#61
alfetopito wants to merge 1 commit intodevelopmentfrom
tooltip-component

Conversation

@alfetopito
Copy link
Contributor

Description

New Tooltip component following the new design.

screenshot_2020-08-21_11-04-49

Notes:

Could not make the props load on the storybook for this component. What am I missing?
screenshot_2020-08-21_11-08-32

@alfetopito alfetopito self-assigned this Aug 21, 2020
@alfetopito alfetopito requested a review from mmv08 August 21, 2020 18:09
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Aug 21, 2020

Travis automatic deployment:
https://pr61--safereactcomponents.review.gnosisdev.com


export type Props = Omit<TooltipProps, 'arrow'>;

const StyledToolTip = withStyles(() => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicosampler
Copy link
Contributor

Could not make the props load on the storybook for this component. What am I missing?

I had this problem before, don't remember what was the problem I'll take a look later.

Copy link
Contributor

@nicosampler nicosampler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles should be the same as the one used on the Icon and Text component.

Also, would be good if the current tooltips are replaced by this new component.

@dasanra dasanra added the enhancement New feature or request label Sep 23, 2020
@nicosampler
Copy link
Contributor

Thx for this PR, it was implemented in #92.

@alfetopito alfetopito deleted the tooltip-component branch February 16, 2021 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants