Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Components new design#77

Merged
dasanra merged 29 commits intodevelopmentfrom
components-new-design
Dec 14, 2020
Merged

Components new design#77
dasanra merged 29 commits intodevelopmentfrom
components-new-design

Conversation

@nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Nov 25, 2020

Components for 5afe/safe-react#1648.

  • NEW Dot component
  • CHANGE: add a strong prop to titles
  • CHANGE: add new button type outlined-bordered.
  • CHANGE: add a disabled prop to card.

@nicosampler nicosampler marked this pull request as draft November 25, 2020 17:57
@github-actions
Copy link

github-actions bot commented Nov 25, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 25, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Nov 25, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Nov 25, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Nov 26, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Nov 26, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Nov 27, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Nov 27, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@nicosampler nicosampler marked this pull request as ready for review November 27, 2020 16:18
@ghost
Copy link

ghost commented Nov 27, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Nov 27, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Nov 27, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good so far.

@ghost
Copy link

ghost commented Dec 2, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Dec 2, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Dec 2, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Dec 2, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Dec 2, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Dec 3, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@alongoni alongoni requested a review from fernandomg December 3, 2020 17:29
Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 LGTM!

height: 100%;
width: 100%;
background-color: ${({ theme }) => theme.colors.white};
z-index: 999;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the z-index criteria for the whole library?

why it's 999?

@ghost
Copy link

ghost commented Dec 9, 2020

Travis automatic deployment:
https://pr77--safereactcomponents.review.gnosisdev.com

@nicosampler nicosampler requested a review from dasanra December 14, 2020 11:29
@dasanra dasanra merged commit bf3a844 into development Dec 14, 2020
@dasanra dasanra deleted the components-new-design branch December 14, 2020 11:36
@dasanra dasanra mentioned this pull request Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants