This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Merged
Conversation
added 2 commits
December 11, 2020 10:59
This change makes it possible to set <input> HTML's props like min and max values, by passing them onto <TextField> `input` obj
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
nicosampler
approved these changes
Dec 11, 2020
Contributor
Author
|
Can I merge this? Or will any of you do it? |
dasanra
approved these changes
Jan 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
<TextField>component, nowinputPropsare passed down to MUI component.MUI reference https://material-ui.com/api/text-field/
With this change,
<TextField>inputprops now can contain HTML props and properly pass it down to inner<input>element.Added a Story for testing it with a
numberinput withminandmaxset