Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix/Button: Fix styles and complete reimplementation#94

Merged
dasanra merged 7 commits intodevelopmentfrom
fix/refactor-button
Feb 18, 2021
Merged

Fix/Button: Fix styles and complete reimplementation#94
dasanra merged 7 commits intodevelopmentfrom
fix/refactor-button

Conversation

@nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Feb 14, 2021

  • support all buttons variants
  • write CSS rules in a simpler way

@dasanra dasanra marked this pull request as ready for review February 15, 2021 17:08
@@ -176,9 +174,7 @@ export const withCustomComponent = (): React.ReactElement => {
color="secondary"
component={Link}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with component after the refactor. Is not recognized as a valid property

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dasanra good catch! it should be fixed now!

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Feb 17, 2021

Travis automatic deployment:
https://pr94--safereactcomponents.review.gnosisdev.com

@dasanra dasanra merged commit b9c578a into development Feb 18, 2021
@dasanra dasanra deleted the fix/refactor-button branch February 18, 2021 19:55
@dasanra dasanra mentioned this pull request Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants