Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

[Onboard] - Ledger improvements #1259

@matextrem

Description

@matextrem

The blocknative team has recently received some feedback from the Ledger team regarding their Ledger wallet implementation in Onboard.js, and they suggested some improvements.

The improvements involve detecting the OS and Browser combination that the user has and then using the best transport for that combination. The transport that we default to (U2F) won't work correctly for users on Windows 10 (where we had some users experiencing issues).

So they have implemented the changes on this branch: https://github.com/blocknative/onboard/tree/enhancement/ledger-transport. If a transport is passed in via the Ledger initialization object, then it will default to that transport, but otherwise it will run some logic to determine the best transport for the user.

We need to battle test it before releasing to make sure it is working well across a variety of devices

Metadata

Metadata

Assignees

Labels

Enhancement ✨Minor Improvement / changes to existing functionalityMajorNeeds to be fixed for immediate next public release.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions