[Safe apps] Make Safe apps network specific

[pablofullana]

What is this feature about? (1 sentence)

This will only display Safe apps that works on the respective network.

Why is it needed? What is the value? For whom do we build it?

• Our interface is available on mainnet and rinkeby
  • With xDai compatibility #1353 we add xDAI support
  • With EWC & Volta compatibility #1253 we add EWC and Volta support
• Not all Safe apps existing on all different networks

High-level overview of the feature

• Make Safe apps network specific, i.e. it should be possible for each Safe app which is added by us to determine on which networks they should be displayed.

Mainnet

• All existing Safe apps should be displayed, i.e.
  • 1inch
  • Aave
  • Balancer Exchange + Pool
  • Compound
  • Idle
  • OpenZeppelin
  • Request
  • Sablier
  • Synthetix
  • Tx builder
  • Yearn vaults
  • WalletConnect

Rinkeby

• The following Safe apps should be displayed (i.e. only the ones that work on Rinkeby)
  • Idle
  • OpenZeppelin
  • Request
  • Sablier
  • WalletConnect
  • Tx builder

xDAI, EWC, Volta

• The following Safe apps should be displayed (i.e. only the ones that work on these 3 networks)
  • OpenZeppelin
  • WalletConnect
  • Tx builder

[nicosampler]

We should think about how to handle this, if we want each safe-app to let the safe know which networks are supported (through manifest.json) we will need a re-deploy for all the apps. Otherwise, we should handle default values per app.

[tschubotz]

We should think about how to handle this, if we want each safe-app to let the safe know which networks are supported (through manifest.json) we will need a re-deploy for all the apps. Otherwise, we should handle default values per app.

@nicosampler Does it have to be so complicated? We anyway manually add Safe apps somewhere in the safe-react code, right? Couldn't we there just specify on which networks they work in our code? What advantage would it have if that info is in the manifest?

[lukasschor]

At some point we should switch to not manually adding Safe Apps in safe-react (see #990). Seeing the amount of Safe App additions & updates we probably have to tackle this rather sooner than later. So in that context it might make sense to have at least new apps specify their network in the manifest, even if we initially assign networks to the apps ourselves manually. Also, this would already reduce the overhead of asking Safe Apps developers what networks the app is compatible with or finding it out ourselves through trial/error.

[nicosampler]

@fernandomg @dasanra should we hardcode the allowed networks in the app list as a temporary solution? https://github.com/gnosis/safe-react/blob/development/src/routes/safe/components/Apps/utils.ts#L18

[fernandomg]

@fernandomg @dasanra should we hardcode the allowed networks in the app list as a temporary solution? https://github.com/gnosis/safe-react/blob/development/src/routes/safe/components/Apps/utils.ts#L18

Yes, as we agreed the last week. This will just work and work well as an initial approach.

WDYT about using this list of networks in the Safe side as a fallback if the apps don't provide a "networks" key in their manifest?

[nicosampler]

@fernandomg sounds good, but until we define how the manifest should be I would skip that idea. Also not any safe-app is providing that key.

[fernandomg]

@nicosampler, oops. I didn't know networks keys were already defined in the manifest file. I was suggesting a new key for this feature, so the apps can add it whenever they can.

[nicosampler]

ok, I see your point, I remember we talked about it, but what networks should be the default, mainnet and rinkeby?

I think if we request the safe-apps to add the network key, it should be mandatory, could be unsafe to ensure it will work in a network if it doesn't.