[Safe App] Aave v1.2

[lukasschor]

There is a new update for the Aave Safe App: https://github.com/aave/gnosis-safe-app/releases/tag/1.2

• Code review
• QA
• Add to IPFS & pin
• Add to safe-react

[dasanra]

Code seems fine. Loads correctly. Only able to test on mainnet:

https://gateway.pinata.cloud/ipfs/Qmcs2UnBZwrjmPRz4HAQb5d8KsW6aXfS8pnFteiorwoE5c

[francovenica]

Safe and env used: https://gnosis-safe.io/app/#/safes/0x8675B754342754A30A2AeF474D114d8460bca19b/apps

Tried to deposit 1 DAI and I got this error. Tried the same with 0.2 DAI and I had the same error
I have 6.5+ DAI in the safe, so funds is no issue

The console

I wasn't able to sign anything, it fails in the app right away @dasanra

[dasanra]

This should be fixed in this test version:
https://gateway.pinata.cloud/ipfs/QmZiZ2h1YrSCAhhxRjQ8cCc6iHtssRbXxXV3oovLGm1b17/

[francovenica]

I tried this in both, the rinkeby prod env and mainnet prod env

RInkeby: https://rinkeby.gnosis-safe.io/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/apps
https://gnosis-safe.io/app/#/safes/0x8675B754342754A30A2AeF474D114d8460bca19b/balances

I added in both the URL given in the previous comment

• In rinkeby I was able to add the app, but the tokens show no funds.
  I have USDC, SNX, ETH, DAI... none of them showed any tokens in the Aave app
  

• In prod the funds can be seen in the app, but the tx always fail when I try to sign it. The signature is an "off chain" type of tx.
  This new URL is only for testing env? if that's the case then maybe is that why it fails every time
  
  

Tried regular tx (send funds) signatures and I had no issues, so tx themselves are working properly

[dasanra]

Issue was related to the link length. This can be tested here:
https://ipfs.gnosisdev.com/ipfs/QmX1NUtvm9WjbvT79sTdeg3sw1NxZAM273y44nBy5d2jZb/

[francovenica]

Tried again with a new URL and it worked fine
Tested here: https://gnosis-safe.io/app/#/safes/0x8675B754342754A30A2AeF474D114d8460bca19b/balances

App URL: https://ipfs.gnosisdev.com/ipfs/QmX1NUtvm9WjbvT79sTdeg3sw1NxZAM273y44nBy5d2jZb/