Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

[xDai] Review RPC interactions and properly handle return values #1457

@fernandomg

Description

@fernandomg

One of the issues that arose during the implementation of xDai:

image.png

remoteOwner was null as the RPC call failed to succeed.

We need to be sure that all the interactions with the RPC are properly handled (also, for this particular case https://github.com/gnosis/safe-react/blob/b7afc5caea6e57473152afc8f1bb598358aca4e4/src/logic/contracts/generateBatchRequests.ts#L13 should be properly typed)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions