You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 10, 2023. It is now read-only.
As discussed internally we would need to refactor our current gas calculation, currently, we have this approach:
After the discussion with Richard we decided to go this way:
The logic of estimating the gas should be independent of the current threshold value
After the refactor we should have something like:
1) estimateGasForTxCreation:
When tx is created -> safe.requiredTxGas
2) estimateGasForTxExecution:
When tx is executed -> web3.estimateGas
3) estimateGasForApproval:
- For on chain approval -> web3.estimateGas
- For off chain approval -> no need to estimate anything
- Note: as we don't know if an approval will be off or on chain we will assume it is on chain