Tx marked as "This transaction will most likely fail" even though it doesn't

[tschubotz]

This is based on a report from an external team on Slack, however I reproduced this on Rinekby.

Title/Description

Tx marked as "This transaction will most likely fail" even though it doesn't

Environment

• Browser: Firefox
• Safe: https://rinkeby.gnosis-safe.io/app/#/safes/0xaE3c91c89153DEaC332Ab7BBd167164978638c30/transactions
• Wallet: Metamask
• App Version: 2.18.0
• Environment:
  • production (rinkeby)

Steps to reproduce

Prerequisites:

• I deployed a special ERC721 token: https://rinkeby.etherscan.io/address/0xAd9104d92DB0215A4397511f06E79C01bA757c1a#code
• Transferred ownership to my Safe address from above.
• I minted 1 token with id=7 to 0x00984CBdcAc32676d811f5bDB82bC50ae6dd6784 (an EOA)

Now the actual steps:

1. Open contract interaction.
2. use the erc721 token address from above (0xAd9104d92DB0215A4397511f06E79C01bA757c1a)
3. select transferFrom
4. Enter id=7 to from=0x00984CBdcAc32676d811f5bDB82bC50ae6dd6784 and to=0x0e329fa8d6Fcd1ba0Cda495431F1f7CA24F442C2
5. Review and create tx with owner 1
6. Now with owner 2, try to confirm the tx

Expected result

No warning

Obtained result

Warning shows up.

Misc

• NOTE: I was NOT able to reproduce this is a 2/8 Safe. Only after I changed the threshold to 3/8, the error appeared. Also I was NOT able to reproduce this when deploying the token contract without optimization. (Could be coincidence or not, just wanted to mention that.
• Ultimately the tx didn't fail: https://rinkeby.etherscan.io/tx/0xc4139954e172ca43082ffce0ec9fcc5ff75d69ecc4ca36f576adb3665e173c77 (also on the execution popup the alert wasn't show.)

Screenshots

[tschubotz]

closing as it's not reproducible. I actually did execute it before already, hence the error above is expected.

[tschubotz]

Alright, now reliably reproducible, I updated the steps above. Reopening.

[tschubotz]

I had the same issue with sending testnet DAI with my Safe: https://rinkeby.gnosis-safe.io/app/#/safes/0xaE3c91c89153DEaC332Ab7BBd167164978638c30/transactions just now.