Conversation
|
Travis automatic deployment: |
…to transactions_new
Adds types on fetchTransactions
Adds urlParams to fetchAllTransactions
src/routes/safe/store/actions/transactions/fetchTransactions/index.ts
Outdated
Show resolved
Hide resolved
src/routes/safe/store/actions/transactions/fetchTransactions/index.ts
Outdated
Show resolved
Hide resolved
| safeAddress: string | ||
| limit?: number | ||
| offset?: number | ||
| orderBy?: string // todo: maybe this should be key of MultiSigTransaction | keyof EthereumTransaction |
There was a problem hiding this comment.
not sure to understand the comment
There was a problem hiding this comment.
because the orderBy parameter is used to order the return fields based on the name of one transaction field (as far I understood the API docs). So basically each one of the keys of MultiSigTransaction / EthereumTransaction could be used
There was a problem hiding this comment.
it's not 100% guaranteed that api will support sorting by all fields, so this has to be synced with api
There was a problem hiding this comment.
I think we should wait for implementing once we got the final version of the middleware, what do you think? cc @nicosampler
src/routes/safe/store/actions/transactions/fetchTransactions/loadAllTransactions.ts
Show resolved
Hide resolved
src/routes/safe/store/actions/transactions/fetchTransactions/loadAllTransactions.ts
Outdated
Show resolved
Hide resolved
src/routes/safe/store/actions/transactions/fetchTransactions/loadAllTransactions.ts
Show resolved
Hide resolved
…to transactions_new # Conflicts: # src/logic/safe/store/actions/__tests__/utils.test.ts # src/logic/safe/store/actions/addSafeModules.ts # src/logic/safe/store/reducer/safe.ts # src/logic/safe/store/reducer/types/safe.d.ts # src/routes/safe/components/Apps/index.tsx # src/routes/safe/components/Layout/Tabs/index.tsx # src/routes/safe/components/Settings/Advanced/dataFetcher.ts # src/routes/safe/components/Transactions/TxsTable/ExpandedTx/OwnersColumn/index.tsx # src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/CustomDescription.tsx # src/routes/safe/container/hooks/useFetchTokens.tsx # src/routes/safe/container/hooks/useLoadSafe.tsx # src/routes/safe/store/reducer/types/safe.d.ts # src/routes/safe/store/reducer/types/safe.ts
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
Travis automatic deployment: |
| import { Transaction, TxType } from '../../../models/types/transactions' | ||
|
|
||
| export const isMultiSigTx = (tx: Transaction): boolean => { | ||
| return TxType[tx.txType] === TxType.MULTISIG_TRANSACTION |
There was a problem hiding this comment.
nitpick: TxType[tx.type] looks weird, can we come up with a better name for this?
| } | ||
|
|
||
| const etagsByPage = {} | ||
| let totalTransactionsAmount = null |
There was a problem hiding this comment.
this number is unique for each safe but this action used for all safes, do we need really need to store it there?
could we maybe do something like
transactions: {
safeAddress: {
totalCount: 1000,
data: []
}
}
There was a problem hiding this comment.
It was done like that before and you asked me to change it
There was a problem hiding this comment.
@mikheevm do you have access to previous implementation? if so, could you please verify if former one was correct? just to avoid re-writing it in case we go back to it.
There was a problem hiding this comment.
Here is the old implementation, it wasn't done like that
There was a problem hiding this comment.
In the old implementation totalTransactionsAmount was defined at top level instead of being specific to the safe
|
CLA Assistant Lite All Contributors have signed the CLA. |
Add Balancer Pool and Exchange Apps.
|
Travis automatic deployment: |
|
CLA Assistant Lite All Contributors have signed the CLA. |
…to transactions_new # Conflicts: # src/components/Header/components/ProviderDetails/UserDetails.tsx # src/routes/safe/components/Apps/index.tsx
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
Travis automatic deployment: |
6 participants
Closes #354