Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Tech Debt: Safe Apps Refactor#1110

Merged
mmv08 merged 19 commits intodevelopmentfrom
feature/apps-return-hash
Aug 6, 2020
Merged

Tech Debt: Safe Apps Refactor#1110
mmv08 merged 19 commits intodevelopmentfrom
feature/apps-return-hash

Conversation

@mmv08
Copy link
Contributor

@mmv08 mmv08 commented Jul 13, 2020

This PR refactors the Safe apps tab:

  • Extract LegalDisclaimer component
  • Move appList logic (loading, toggling, adding apps) to useAppList hook
  • Add useLegalConsent hook
  • Improve types for saveToStorage function

TODO:

  • Add useIframeMessageHandler hook for communication login between app <> safe app. This PR is already pretty big so I decided to work on it in a separate PR

@ghost
Copy link

ghost commented Jul 13, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 14, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 14, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@github-actions
Copy link

github-actions bot commented Jul 31, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jul 31, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Jul 31, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@mmv08 mmv08 marked this pull request as ready for review July 31, 2020 12:22
@ghost
Copy link

ghost commented Jul 31, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@mmv08 mmv08 requested a review from dasanra July 31, 2020 16:10
@ghost
Copy link

ghost commented Aug 3, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Aug 3, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Aug 4, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@ghost
Copy link

ghost commented Aug 4, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Aug 6, 2020

Travis automatic deployment:
https://pr1110--safereact.review.gnosisdev.com/app

@mmv08 mmv08 merged commit b6bb5ff into development Aug 6, 2020
@mmv08 mmv08 deleted the feature/apps-return-hash branch August 6, 2020 07:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants