Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Fix - Owners list error#1127

Merged
mmv08 merged 15 commits intodevelopmentfrom
bugfix/addressBook-owners
Jul 28, 2020
Merged

Fix - Owners list error#1127
mmv08 merged 15 commits intodevelopmentfrom
bugfix/addressBook-owners

Conversation

@matextrem
Copy link
Contributor

closes #1111

@matextrem matextrem added Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release. labels Jul 21, 2020
@matextrem matextrem added this to the Sprint 9 milestone Jul 21, 2020
@matextrem matextrem self-assigned this Jul 21, 2020
@matextrem matextrem requested a review from fernandomg July 21, 2020 04:33
@ghost
Copy link

ghost commented Jul 21, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 21, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

@github-actions
Copy link

github-actions bot commented Jul 21, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 9 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 9 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jul 21, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 21, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Jul 21, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

@matextrem matextrem requested a review from mmv08 July 21, 2020 16:47
@ghost
Copy link

ghost commented Jul 21, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

Co-authored-by: Fernando <fernando.greco@gmail.com>
@ghost
Copy link

ghost commented Jul 21, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 22, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 23, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

@francovenica
Copy link
Contributor

I don't know what that ESLint Summary is all about, but I see that the issue of the page crashing is not happening anymore.

So at least in functionality is working fine

@ghost
Copy link

ghost commented Jul 24, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 28, 2020

Travis automatic deployment:
https://pr1127--safereact.review.gnosisdev.com/app

@mmv08 mmv08 merged commit 8a6b219 into development Jul 28, 2020
@mmv08 mmv08 deleted the bugfix/addressBook-owners branch July 28, 2020 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Going to Settings > Owners after creating a safe crashes the page

4 participants