Trim spaces from AddressInput by dasanra · Pull Request #1142 · 5afe/safe-react

dasanra · 2020-07-22T16:24:03Z

Remove lead/end white spaces in address input fields

… removed Fix function documentation in string util

github-actions · 2020-07-22T16:28:34Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	14	0
Ignored	0	N/A

Result: ✅ success
Annotations: 14 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/routes/load/components/DetailsForm/index.tsx Line 43 - Missing return type on function.
src/routes/load/components/DetailsForm/index.tsx Line 43 - Argument 'values' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 151 - Missing return type on function.
src/routes/load/components/DetailsForm/index.tsx Line 151 - Argument 'controls' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 151 - Object pattern argument should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Argument 'index' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Argument 'notRemovedOwners' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Argument 'values' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Object pattern argument should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Argument 'controls' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Object pattern argument should be typed.
src/utils/strings.ts Line 19 - Missing return type on function.

^{Report generated by eslint-plus-action}

github-actions · 2020-07-22T16:28:42Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	17	0
Ignored	0	N/A

Result: ✅ success
Annotations: 17 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/forms/Field/DebounceValidationField.tsx Line 8 - Missing return type on function.
src/components/forms/Field/DebounceValidationField.tsx Line 8 - Object pattern argument should be typed with a non-any type.
src/routes/load/components/DetailsForm/index.tsx Line 43 - Missing return type on function.
src/routes/load/components/DetailsForm/index.tsx Line 43 - Argument 'values' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 151 - Missing return type on function.
src/routes/load/components/DetailsForm/index.tsx Line 151 - Argument 'controls' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 151 - Object pattern argument should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Argument 'index' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Argument 'notRemovedOwners' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Argument 'values' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Object pattern argument should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Argument 'controls' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Object pattern argument should be typed.
src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.tsx Line 51 - Object pattern argument should be typed.
src/utils/strings.ts Line 19 - Missing return type on function.

^{Report generated by eslint-plus-action}

ghost · 2020-07-22T16:35:29Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

ghost · 2020-07-22T16:36:25Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

ghost · 2020-07-22T18:10:05Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

fernandomg

Looking good.

There's only one place where it still not working, in the Assets->Coins/Manage List, when trying to add a custom token:

ghost · 2020-07-23T15:12:03Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

dasanra · 2020-07-23T16:06:16Z

Just in case, I'm currently working on this changes

ghost · 2020-07-24T11:01:27Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

ghost · 2020-07-27T10:42:17Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

mmv08 · 2020-07-27T11:11:21Z

src/components/forms/AddressInput/index.tsx

+  placeholder?: string
+  inputAdornment?: { endAdornment: React.ReactElement } | undefined
+  testId: string
+  validators?: Array<(data: string) => string>


You can use Validator type from https://github.com/gnosis/safe-react/blob/development/src/components/forms/validator.ts#L10

I'm having difficulties integrating it. This type doesn't fit 100% with current implementation. I'm having issues to use it with an empty array

Found the issue why it wasn't working. I was using it wrong. Now it's working

src/components/forms/AddressInput/index.tsx

francovenica · 2020-07-27T14:29:38Z

Checked

Load safe
Send funds
Send collectibles
Contract interaction (Both forms)
Address book when you add new entries
Add owner, replace owner
Create safe when you add owners

The one that Fer pointed out later is still missing to be fixed, the one in the "Add custom apps" form

ghost · 2020-07-27T15:55:19Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

ghost · 2020-07-28T08:08:11Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

ghost · 2020-07-28T10:05:57Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

dasanra · 2020-07-28T10:12:23Z

@fernandomg is ready for review

francovenica · 2020-07-29T12:11:47Z

The "Add custom app" input was fixed.
Looks good to me

ghost · 2020-07-29T12:30:10Z

Travis automatic deployment:
https://pr1142--safereact.review.gnosisdev.com/app

matextrem and others added 3 commits July 17, 2020 19:00

Remove spaces

dff1b40

Merge with development

3c9edfe

Change naming convention to make clear that only edge whitespaces are…

1883eff

… removed Fix function documentation in string util

dasanra requested a review from matextrem July 22, 2020 16:24

dasanra self-assigned this Jul 22, 2020

dasanra added the Bug 🐛 Something isn't working label Jul 22, 2020

Merge branch 'development' into feature/remove-spaces

3243507

matextrem self-assigned this Jul 22, 2020

matextrem added this to the Sprint 9 milestone Jul 22, 2020

Merge branch 'development' into feature/remove-spaces

7ecd3af

matextrem requested review from fernandomg and mmv08 July 22, 2020 17:55

fernandomg suggested changes Jul 22, 2020

View reviewed changes

Merge branch 'development' into feature/remove-spaces

8a83a7b

matextrem requested a review from fernandomg July 23, 2020 15:01

dasanra added the WIP label Jul 23, 2020

Merge branch 'development' into feature/remove-spaces

2596d8c

Add trim spaces from address input in AddToken and AddAsset

51c8a6f

dasanra removed the WIP label Jul 27, 2020

mmv08 reviewed Jul 27, 2020

View reviewed changes

Merge branch 'development' into feature/remove-spaces

f36d84e

Use validator type

c8c8db9

mmv08 approved these changes Jul 28, 2020

View reviewed changes

Merge branch 'development' into feature/remove-spaces

7227736

Trim spaces on Safe App links

6f3fb6a

Merge branch 'development' into feature/remove-spaces

55e81d4

fernandomg approved these changes Jul 29, 2020

View reviewed changes

mmv08 merged commit 89c1718 into development Jul 29, 2020

mmv08 deleted the feature/remove-spaces branch July 29, 2020 13:28

Conversation

dasanra commented Jul 22, 2020

Uh oh!

github-actions bot commented Jul 22, 2020

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

github-actions bot commented Jul 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Jul 22, 2020

Uh oh!

ghost commented Jul 22, 2020

Uh oh!

ghost commented Jul 22, 2020

Uh oh!

fernandomg left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jul 23, 2020

Uh oh!

dasanra commented Jul 23, 2020

Uh oh!

ghost commented Jul 24, 2020

Uh oh!

ghost commented Jul 27, 2020

Uh oh!

mmv08 Jul 27, 2020

Choose a reason for hiding this comment

Uh oh!

dasanra Jul 27, 2020

Choose a reason for hiding this comment

Uh oh!

dasanra Jul 27, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

francovenica commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 27, 2020

Uh oh!

ghost commented Jul 28, 2020

Uh oh!

ghost commented Jul 28, 2020

Uh oh!

dasanra commented Jul 28, 2020

Uh oh!

francovenica commented Jul 29, 2020

Uh oh!

ghost commented Jul 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Jul 22, 2020 •

edited

Loading

francovenica commented Jul 27, 2020 •

edited

Loading