Fix CI on github action desktop build

[matextrem]

No description provided.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[mmv08]

@matextrem could you please give an example of warning that didn't let the build happen?

[ghost]

Travis automatic deployment:
https://pr1159--safereact.review.gnosisdev.com/app

[mmv08]

ok I see it in https://github.com/gnosis/safe-react/runs/906180676

this is why we started using react-app-rewired, we have a configuration override which should suppress this warning: https://github.com/gnosis/safe-react/blob/development/config-overrides.js

why doesn't it work?

[matextrem]

The CI fails if it detect warnings. In windows there are 2 warnings related to critical dependencies.

[ghost]

Travis automatic deployment:
https://pr1159--safereact.review.gnosisdev.com/app

[mmv08]

@matextrem I understand that. We previously had exactly the same issue and fixed it, I pointed you to the file with the solution. If we merge your PR, we will have two solutions for the same problem. Did you investigate why the current solution doesn't work for windows?

Also I'm not really a fan of CI=false, this way we may miss other possible warnings

[ghost]

Travis automatic deployment:
https://pr1159--safereact.review.gnosisdev.com/app