This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Fix: Standardized modal alignment settings#1160
Merged
mmv08 merged 2 commits intodevelopmentfrom Jul 27, 2020
Merged
Conversation
|
Travis automatic deployment: |
fernandomg
approved these changes
Jul 24, 2020
|
Travis automatic deployment: |
Contributor
|
Please check how all the modals display on smaller screens, the reason that modals were unaligned is because the modals with greater height would be cut on smaller screens (for example, MacBook 12) if they would be aligned on center |
Contributor
|
Oh, didn't notice that they are aligned from topbar, sorry |
mmv08
approved these changes
Jul 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1147
Now all modals have the same alignment settings (120px from top navbar).
Maybe we have to think to implement Generic Modal from safe-react-component.