Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Fix: Standardized modal alignment settings#1160

Merged
mmv08 merged 2 commits intodevelopmentfrom
issue-1147
Jul 27, 2020
Merged

Fix: Standardized modal alignment settings#1160
mmv08 merged 2 commits intodevelopmentfrom
issue-1147

Conversation

@alongoni
Copy link
Contributor

Closes #1147
Now all modals have the same alignment settings (120px from top navbar).

Screenshot from 2020-07-24 14-25-41
Screenshot from 2020-07-24 14-26-05

Maybe we have to think to implement Generic Modal from safe-react-component.

@alongoni alongoni self-assigned this Jul 24, 2020
@alongoni alongoni requested a review from francovenica July 24, 2020 17:34
@alongoni alongoni added the Bug 🐛 Something isn't working label Jul 24, 2020
@alongoni alongoni changed the title (fix) Standardized modal alignment settings Fix: Standardized modal alignment settings Jul 24, 2020
@github-actions
Copy link

github-actions bot commented Jul 24, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 30 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 30 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jul 24, 2020

Travis automatic deployment:
https://pr1160--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Jul 24, 2020

Travis automatic deployment:
https://pr1160--safereact.review.gnosisdev.com/app

@mmv08
Copy link
Contributor

mmv08 commented Jul 24, 2020

Please check how all the modals display on smaller screens, the reason that modals were unaligned is because the modals with greater height would be cut on smaller screens (for example, MacBook 12) if they would be aligned on center

@mmv08
Copy link
Contributor

mmv08 commented Jul 24, 2020

Oh, didn't notice that they are aligned from topbar, sorry

@lukasschor lukasschor self-requested a review July 27, 2020 09:51
Copy link
Contributor

@lukasschor lukasschor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmv08 mmv08 merged commit 93448b5 into development Jul 27, 2020
@mmv08 mmv08 deleted the issue-1147 branch July 27, 2020 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modals have different alignment settings

4 participants