This repository was archived by the owner on Nov 10, 2023. It is now read-only.
(Fix) Prevent accessing contentWindow if iframe is null#1161
Merged
fernandomg merged 1 commit intodevelopmentfrom Jul 24, 2020
Merged
(Fix) Prevent accessing contentWindow if iframe is null#1161fernandomg merged 1 commit intodevelopmentfrom
contentWindow if iframe is null#1161fernandomg merged 1 commit intodevelopmentfrom
Conversation
fernandomg
added
Bug 🐛
fernandomg
requested review from
francovenica,
germartinez,
mmv08 and
nicosampler
nicosampler
approved these changes
Jul 24, 2020
germartinez
approved these changes
Jul 24, 2020
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
francovenica
approved these changes
Jul 24, 2020
Contributor
francovenica
left a comment
francovenica
left a comment
There was a problem hiding this comment.
Works. Page doesn't crashes anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the issue in
developmentthat prevents the app from starting up