Avoid constant creation of new web3 object

[dasanra]

Currently we are creating a new web3 object each 3 seconds.

When we query for network info it's enough to check with current web3 instance. Web3 update logic should be handled elsewhere.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	8	0
Ignored	3	N/A

• Result: ✅ success

• Annotations: 8 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/components/ConnectButton/index.tsx Line 68 - Argument 'props' should be typed.
• src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Missing return type on function.
• src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Argument 'dispatch' should be typed.
• src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Argument 'provider' should be typed.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 21 - Argument 'store' should be typed.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 21 - Argument 'next' should be typed.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 21 - Missing return type on function.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 21 - Argument 'action' should be typed.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1171--safereact.review.gnosisdev.com/app

[mmv08]

would it be possible to make it use passed web3 instead of using a global module variable?

[dasanra]

Yes, if it's more explicit it's not a problem. Anyway we are always using a getter to get that web3 instance (from the same file)

[ghost]

Travis automatic deployment:
https://pr1171--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1171--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1171--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1171--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1171--safereact.review.gnosisdev.com/app

[mmv08]

Sorry for not saying this earlier: So it was implemented this way because of some weird behaviour in onboard.js when switching providers, I don't remember what exactly it was. The thing that if user changes a provider we need to use it to reinitialise the contracts and stuff. But now it looks like setWeb3 function from getWeb3.ts takes care of it and thus we don't need to recreate it.