Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

New layout#1201

Merged
mmv08 merged 83 commits intodevelopmentfrom
new-layout
Aug 27, 2020
Merged

New layout#1201
mmv08 merged 83 commits intodevelopmentfrom
new-layout

Conversation

@nicosampler
Copy link
Contributor

Adding the new layout as a safe-react component based on invision design.

closes #1121.

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 3 0
Ignored 6 N/A
  • Result: ✅ success

  • Annotations: 3 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@nicosampler nicosampler requested a review from mmv08 August 25, 2020 12:14
@ghost
Copy link

ghost commented Aug 25, 2020

Travis automatic deployment:
https://pr1201--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Aug 26, 2020

Travis automatic deployment:
https://pr1201--safereact.review.gnosisdev.com/app

@mmv08
Copy link
Contributor

mmv08 commented Aug 26, 2020

@nicosampler Got your point. I will make a separate container for sidebar tomorrow. Just wanted to move away logic unique to the sidebar from top-level App component

@ghost
Copy link

ghost commented Aug 27, 2020

Travis automatic deployment:
https://pr1201--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Aug 27, 2020

Travis automatic deployment:
https://pr1201--safereact.review.gnosisdev.com/app

@mmv08
Copy link
Contributor

mmv08 commented Aug 27, 2020

@mmv08 mmv08 merged commit 03cb4ab into development Aug 27, 2020
@mmv08 mmv08 deleted the new-layout branch August 27, 2020 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Basic Layout Redesign

6 participants