(Feature) Add unit tests by Agupane · Pull Request #1230 · 5afe/safe-react

Agupane · 2020-08-11T13:44:35Z

Description

Added unit tests for the following files:

AddressBookUtils.ts
fetchSafeTokens.ts
tokenHelpers.ts
ethAddresses.ts
transactionHelpers.ts
actions/utils.ts
safeBalances.ts

Also added types for addressBook and fixed a bug on the isERC721Contract method

I tried to avoid the interaction with web3, just tested our logic and added some mock functions for transactions, safeInstance

Please ignore the branch name, it was intended to be a ganache removal pr but then we discussed internally that will be better if we just start adding easy-tests as a first approach to have a basis and then we could start another pr with more complex tests

And getNewTxNonce

…to remove-ganache

Adds generateSafeTxHash test

github-actions · 2020-08-11T13:44:51Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-08-11T13:49:25Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	2	0
Ignored	8	N/A

Result: ✅ success
Annotations: 2 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Missing return type on function.
src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Object pattern argument should be typed.

^{Report generated by eslint-plus-action}

ghost · 2020-08-11T13:59:23Z

Travis automatic deployment:
https://pr1230--safereact.review.gnosisdev.com/app

ghost · 2020-08-11T14:01:12Z

Travis automatic deployment:
https://pr1230--safereact.review.gnosisdev.com/app

ghost · 2020-08-11T15:40:00Z

Travis automatic deployment:
https://pr1230--safereact.review.gnosisdev.com/app

ghost · 2020-08-11T16:55:22Z

Travis automatic deployment:
https://pr1230--safereact.review.gnosisdev.com/app

Adds isModifySettingsTransaction tests Adds isMultiSendTransaction tests Adds isUpgradeTransaction tests Adds isOutgoingTransaction tests Adds isCustomTransaction tests

src/logic/safe/store/tests/safe.balances.test.ts

src/test/logic/addressBook/utils/addressBookUtils.test.ts

src/test/routes/safe/store/actions/utils.test.ts

src/test/logic/token/utils/tokenHelpers.test.ts

src/test/logic/currencyValues/api/fetchSafeTokens.test.ts

…to remove-ganache # Conflicts: # src/logic/addressBook/utils/index.ts # src/logic/safe/store/actions/utils.ts # src/routes/safe/components/Balances/SendModal/screens/AddressBookInput/index.tsx # src/test/safe.dom.balances.ts

ghost · 2020-09-10T13:38:27Z

Travis automatic deployment:
https://pr1230--safereact.review.gnosisdev.com/app

ghost · 2020-09-10T13:43:42Z

Travis automatic deployment:
https://pr1230--safereact.review.gnosisdev.com/app

ghost · 2020-09-10T14:04:21Z

Travis automatic deployment:
https://pr1230--safereact.review.gnosisdev.com/app

Agupane · 2020-09-11T14:46:12Z

Hey @mikheevm just ping you to ask if you are able to check this pr or we should merge it

src/logic/tokens/utils/__tests__/tokenHelpers.test.ts

src/routes/safe/store/actions/transactions/__tests__/utils/transactionHelpers.test.ts

…to remove-ganache

github-actions · 2020-09-14T12:56:52Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	2	0
Ignored	9	N/A

Result: ✅ success
Annotations: 2 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Missing return type on function.
src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Object pattern argument should be typed.

^{Report generated by eslint-plus-action}

ghost · 2020-09-14T13:04:28Z

Travis automatic deployment:
https://pr1230--safereact.review.gnosisdev.com/app

mmv08

This was a very hard one, thank you!
one last comment, please

src/routes/safe/store/actions/transactions/__tests__/utils/transactionHelpers.test.ts

ghost · 2020-09-14T15:35:54Z

Travis automatic deployment:
https://pr1230--safereact.review.gnosisdev.com/app

Agupane added 18 commits August 6, 2020 08:53

Test for balances store

b392818

Types for addressBook.ts

b3d939d

Adds addressBookUtils.test.ts

9b3ffe6

Remove duplicated type

a84df38

Tests for addressBookUtils

12f4843

Adds fetchSafeTokens.test.ts

5541128

Adds getMockedSafeInstance and getMockedTxServiceModel in safeHelper.ts

b58e471

Adds shouldExecuteTransaction tests

e44586a

Fix types for TransactionProps

96173e8

And getNewTxNonce

Adds tests for getNewTxNonce and getLastTx

e9cbf8d

Moves utils.test.tsx to /actions folder

508d40a

Fix file format

36e3f78

Placeholder for transactionHelpers tests

5f52461

Merge branch 'development' of https://github.com/gnosis/safe-react in…

173bcdb

…to remove-ganache

isInnerTransaction tests

90331b2

calculateTransactionStatus tests

aa4ec9b

Adds calculateTransactionType tests

b1caa3a

Adds buildTx test

ffd0176

Adds generateSafeTxHash test

Agupane self-assigned this Aug 11, 2020

Absolute imports

7fae3f8

Agupane added 2 commits August 11, 2020 11:42

Adds types for getRefundParams

ed9e76d

Adds getRefundParams tests

d162ead

Add mock example for isInnerTransaction

850f3ea

Adds isCancelTransaction tests

09dc6c6

Adds isModifySettingsTransaction tests Adds isMultiSendTransaction tests Adds isUpgradeTransaction tests Adds isOutgoingTransaction tests Adds isCustomTransaction tests

mmv08 mentioned this pull request Sep 9, 2020

(Bugfix) Fails to create transaction #1332

Closed

Agupane added 3 commits September 9, 2020 09:27

Add test

03ef0f9

Fix build

52a4f60

Fix build

54fd2e2

mmv08 suggested changes Sep 9, 2020

View reviewed changes

Agupane added 6 commits September 10, 2020 09:46

Reword tests

ca5a4ea

Reword tests

d882cba

Reword tests

86eab46

Fix types

7bb1fdf

Move tests

4d5d49e

Mock contract

8311d3d

Agupane requested a review from mmv08 September 11, 2020 12:37

mmv08 reviewed Sep 11, 2020

View reviewed changes

Agupane added 3 commits September 14, 2020 09:39

Merge branch 'development' of https://github.com/gnosis/safe-react in…

ffda554

…to remove-ganache

Reword tests

49e7694

Reword tests

44488bc

Agupane requested a review from mmv08 September 14, 2020 12:52

mmv08 approved these changes Sep 14, 2020

View reviewed changes

src/routes/safe/store/actions/transactions/__tests__/utils/transactionHelpers.test.ts Show resolved Hide resolved

Move test file

dca355f

dasanra merged commit f1916e9 into development Sep 14, 2020

dasanra deleted the remove-ganache branch September 14, 2020 15:59

github-actions bot locked and limited conversation to collaborators Sep 14, 2020

Conversation

Agupane commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Aug 11, 2020

Uh oh!

github-actions bot commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Aug 11, 2020

Uh oh!

ghost commented Aug 11, 2020

Uh oh!

ghost commented Aug 11, 2020

Uh oh!

ghost commented Aug 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Sep 10, 2020

Uh oh!

ghost commented Sep 10, 2020

Uh oh!

ghost commented Sep 10, 2020

Uh oh!

Agupane commented Sep 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Sep 14, 2020

Uh oh!

mmv08 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost commented Sep 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Agupane commented Aug 11, 2020 •

edited

Loading

github-actions bot commented Aug 11, 2020 •

edited

Loading

github-actions bot commented Sep 14, 2020 •

edited

Loading