Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Fix desktop app build#1254

Merged
mmv08 merged 11 commits intodevelopmentfrom
fix/desktop-app-build
Aug 19, 2020
Merged

Fix desktop app build#1254
mmv08 merged 11 commits intodevelopmentfrom
fix/desktop-app-build

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Aug 18, 2020

Github action to build desktop app is crashing

Add cross-env to contract types generation to fix windows build fail.
Upgrade node version used in electron to v12

@dasanra dasanra self-assigned this Aug 18, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Aug 18, 2020

Travis automatic deployment:
https://pr1254--safereact.review.gnosisdev.com/app

@matextrem matextrem self-requested a review August 19, 2020 17:28
@mmv08 mmv08 merged commit 8a13d33 into development Aug 19, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
@dasanra dasanra deleted the fix/desktop-app-build branch August 26, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants