Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) Types for safe#1274

Merged
mmv08 merged 7 commits intodevelopmentfrom
1176-app-crashes-via-link
Aug 27, 2020
Merged

(Feature) Types for safe#1274
mmv08 merged 7 commits intodevelopmentfrom
1176-app-crashes-via-link

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Aug 25, 2020

Description

@Agupane Agupane requested review from fernandomg and mmv08 August 25, 2020 15:01
@Agupane Agupane self-assigned this Aug 25, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Aug 25, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Aug 25, 2020

Travis automatic deployment:
https://pr1274--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Aug 25, 2020

Travis automatic deployment:
https://pr1274--safereact.review.gnosisdev.com/app

@mmv08
Copy link
Contributor

mmv08 commented Aug 25, 2020

Love this PR! Please keep it up!

@ghost
Copy link

ghost commented Aug 26, 2020

Travis automatic deployment:
https://pr1274--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Aug 27, 2020

Travis automatic deployment:
https://pr1274--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Aug 27, 2020

Travis automatic deployment:
https://pr1274--safereact.review.gnosisdev.com/app

@mmv08 mmv08 merged commit 9fdfd74 into development Aug 27, 2020
@mmv08 mmv08 deleted the 1176-app-crashes-via-link branch August 27, 2020 10:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants