Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) - Update decoded value types#1285

Merged
Agupane merged 5 commits intodevelopmentfrom
update-decoded-value-types
Aug 28, 2020
Merged

(Feature) - Update decoded value types#1285
Agupane merged 5 commits intodevelopmentfrom
update-decoded-value-types

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Aug 27, 2020 •
edited
Loading

Related to #137

@Agupane Agupane requested review from Uxio0 and fernandomg August 27, 2020 14:52
@Agupane Agupane self-assigned this Aug 27, 2020
@github-actions
Copy link

github-actions bot commented Aug 27, 2020

CLA Assistant Lite All Contributors have signed the CLA.

mmv08
mmv08 approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

github-actions bot commented Aug 27, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

Uxio0
Uxio0 reviewed Aug 27, 2020
View reviewed changes
Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agupane Are you taking into account that operation is an integer now (instead of a string)?

@ghost
Copy link

ghost commented Aug 27, 2020

Travis automatic deployment:
https://pr1285--safereact.review.gnosisdev.com/app

dasanra
dasanra suggested changes Aug 27, 2020
View reviewed changes
src/logic/safe/store/models/types/transactions.d.ts

export interface DecodedValue {
export interface ValueDecoded {
operation: Operation
Copy link
Collaborator

@dasanra dasanra Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operation type updated.

Instead
{ CALL = 'CALL', DELEGATE_CALL = 'DELEGATE_CALL', CREATE = 'CREATE', }

Should be type Number

Copy link
Contributor Author

@Agupane Agupane Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok now :)

@Agupane Agupane requested review from Uxio0 and dasanra August 27, 2020 15:44
@ghost
Copy link

ghost commented Aug 27, 2020

Travis automatic deployment:
https://pr1285--safereact.review.gnosisdev.com/app

@dasanra
Copy link
Collaborator

dasanra commented Aug 27, 2020

@Uxio0 will deploy this to staging tomorrow.

If this is merged today should use dev environment for transaction service

@ghost
Copy link

ghost commented Aug 27, 2020

Travis automatic deployment:
https://pr1285--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Aug 28, 2020

Travis automatic deployment:
https://pr1285--safereact.review.gnosisdev.com/app

@Agupane Agupane merged commit e84036c into development Aug 28, 2020
@Agupane Agupane deleted the update-decoded-value-types branch August 28, 2020 11:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Uxio0 Uxio0 Awaiting requested review from Uxio0

3 more reviewers

@fernandomg fernandomg fernandomg approved these changes

@mmv08 mmv08 mmv08 approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Agupane Agupane

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Agupane @dasanra @fernandomg @Uxio0 @mmv08