Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Fix fees not showing in transaction details#1313

Merged
dasanra merged 6 commits intodevelopmentfrom
fix/#1243-fees-always-showing-n-a
Sep 7, 2020
Merged

Fix fees not showing in transaction details#1313
dasanra merged 6 commits intodevelopmentfrom
fix/#1243-fees-always-showing-n-a

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Sep 2, 2020

Fixes #1243

Fees are shown as n/a except for incoming transactions even that transaction service is returning a fee value.
Parse fee value and convert to show on transaction details

@dasanra dasanra self-assigned this Sep 2, 2020
@dasanra dasanra added the Bug 🐛 Something isn't working label Sep 2, 2020
@github-actions
Copy link

github-actions bot commented Sep 2, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 2, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Contributor

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it to the component? So we have less logic before the transactions make their way to the store. Also, it's shown in an expanded transaction view and it doesn't make sense to parse it for all transactions

@mmv08
Copy link
Contributor

mmv08 commented Sep 2, 2020

Sorry didn't finish it in the last comment: we can have only one transaction expanded

@ghost
Copy link

ghost commented Sep 2, 2020

Travis automatic deployment:
https://pr1313--safereact.review.gnosisdev.com/app

@dasanra
Copy link
Collaborator Author

dasanra commented Sep 3, 2020

@mikheevm sure, it can be done. I did it this way because the only transactions that were already showing the fee IncomingTransactions have it already like this on the state. But I'll change both.

@ghost
Copy link

ghost commented Sep 4, 2020

Travis automatic deployment:
https://pr1313--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 4, 2020

Travis automatic deployment:
https://pr1313--safereact.review.gnosisdev.com/app

@lukasschor
Copy link
Contributor

lukasschor commented Sep 4, 2020

image

Can we append "ETH" for the fee (same as Refund)

And would also be great to only show 6 decimals for both Fee and Refund. Metamask does the same.

image

@dasanra
Copy link
Collaborator Author

dasanra commented Sep 7, 2020

@lukasschor

Will add ETH word to the Fee value.

About cutting to 6 decimals I was setting it to display the same decimals as in Etherscan, that is showing up to 9 decimals

@ghost
Copy link

ghost commented Sep 7, 2020

Travis automatic deployment:
https://pr1313--safereact.review.gnosisdev.com/app

@dasanra dasanra requested a review from mmv08 September 7, 2020 10:26
@ghost
Copy link

ghost commented Sep 7, 2020

Travis automatic deployment:
https://pr1313--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Sep 7, 2020

Travis automatic deployment:
https://pr1313--safereact.review.gnosisdev.com/app

@dasanra dasanra merged commit b7afc5c into development Sep 7, 2020
@dasanra dasanra deleted the fix/#1243-fees-always-showing-n-a branch September 7, 2020 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tx details. Fees always showing n/a

3 participants