Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Bugfix) - #1233 Fix method values length in TXs#1314

Merged
nicosampler merged 5 commits intodevelopmentfrom
issue-1233-v2
Sep 21, 2020
Merged

(Bugfix) - #1233 Fix method values length in TXs#1314
nicosampler merged 5 commits intodevelopmentfrom
issue-1233-v2

Conversation

@nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Sep 2, 2020

the second try to close #1233.

@nicosampler nicosampler self-assigned this Sep 2, 2020
@github-actions
Copy link

github-actions bot commented Sep 2, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 2, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 2, 2020

Travis automatic deployment:
https://pr1314--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 3, 2020

Travis automatic deployment:
https://pr1314--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 3, 2020

Travis automatic deployment:
https://pr1314--safereact.review.gnosisdev.com/app

@lukasschor lukasschor changed the title Fix method values length in TXs (Bugfix) - #1233 Fix method values length in TXs Sep 9, 2020
@fernandomg fernandomg self-requested a review September 14, 2020 14:25
fernandomg
fernandomg approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!

image

mmv08
mmv08 reviewed Sep 14, 2020
View reviewed changes
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/Value.tsx Outdated
method: string
type: string
value: string | string[]
value: string | unknown[]
Copy link
Contributor

@mmv08 mmv08 Sep 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the problem there? by looking at the usage it seems the param is always a string

Copy link
Contributor Author

@nicosampler nicosampler Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actions
Copy link

github-actions bot commented Sep 21, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 21, 2020

Travis automatic deployment:
https://pr1314--safereact.review.gnosisdev.com/app

@nicosampler nicosampler merged commit fffabf0 into development Sep 21, 2020
@nicosampler nicosampler deleted the issue-1233-v2 branch September 21, 2020 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@mmv08 mmv08 mmv08 left review comments

@fernandomg fernandomg fernandomg approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nicosampler nicosampler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Long values break Transaction decoding UI

4 participants

@nicosampler @fernandomg @mmv08 @dasanra