Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Bug: incoming transactions do not load if it fails to fetch gas for a transaction#1321

Merged
mmv08 merged 2 commits intodevelopmentfrom
bug/incoming-txs-do-not-load
Sep 4, 2020
Merged

Bug: incoming transactions do not load if it fails to fetch gas for a transaction#1321
mmv08 merged 2 commits intodevelopmentfrom
bug/incoming-txs-do-not-load

Conversation

@mmv08
Copy link
Contributor

@mmv08 mmv08 commented Sep 4, 2020

Dani recently spot this error on this rinkeby safe 0x32d6F7bf55b6692E0d16bFB26317b7D36b494f4a

Screenshot from 2020-09-04 17 02 45

It failed to request gas used by a transaction and then a destructure statement was used on a null value. This PR checks if the returned values are valid

@mmv08 mmv08 requested review from dasanra and fernandomg September 4, 2020 13:10
@github-actions
Copy link

github-actions bot commented Sep 4, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@mmv08 mmv08 changed the title Bug: incoming transactions do not load if it fails to fetch token info Bug: incoming transactions do not load if it fails to fetch gas for a transaction Sep 4, 2020
@github-actions
Copy link

github-actions bot commented Sep 4, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 4, 2020

Travis automatic deployment:
https://pr1321--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 4, 2020

Travis automatic deployment:
https://pr1321--safereact.review.gnosisdev.com/app

@mmv08 mmv08 merged commit 372d27f into development Sep 4, 2020
@mmv08 mmv08 deleted the bug/incoming-txs-do-not-load branch September 4, 2020 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants