(Bugfix) - #1312 Assets disappear when loading a safe

[mmv08]

This PR:

• Closes Force fetch assets when accessing "Assets" tab #1312
• Fixes currency middleware by moving action dispatch to a thunk, middleware was meant to be used for different things: https://redux.js.org/advanced/middleware
• Cleanup the logic for fetching the rates/values/etc
• Remove storing rates as they change frequently
• Fixes storing selected currency

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	3	0
Ignored	0	N/A

• Result: ✅ success

• Annotations: 3 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/logic/currencyValues/store/middleware/index.ts Line 6 - Argument 'next' should be typed.
• src/logic/currencyValues/store/middleware/index.ts Line 6 - Missing return type on function.
• src/logic/currencyValues/store/middleware/index.ts Line 6 - Argument 'action' should be typed.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1333--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1333--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1333--safereact.review.gnosisdev.com/app

[fernandomg]

🥇 this looks nice and clean, but I still see the list of assets cleaning up on the load.

[mmv08]

@fernandomg thanks, for some reason changes to the reducer replacing merge vs mergeDeep disappeared, I have just done them again, please re-test :)

[ghost]

Travis automatic deployment:
https://pr1333--safereact.review.gnosisdev.com/app

[mmv08]

@fernandomg https://pr1333--safereact.review.gnosisdev.com/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/balances a link for easy testing :)

[ghost]

Travis automatic deployment:
https://pr1333--safereact.review.gnosisdev.com/app

[dasanra]

This is not fixing the problem. For me the tokens disappear on the first load, displaying Ether alone. Then after few seconds they appear again.

The mergeDeep is virtually fixing this if applied in line 80 [ADD_SAFE], because we are calling [ADD_SAFE] again after the app is initialized and this is deleting the token values,having to wait until they load again.
I say that this virtually fix it because it introduces another issue. If mergeDeep is applied in [ADD_SAFE] it will add the owners again and again on each reload making the list of owners grow on the same basis as the number of owners we have. They will be shown duplicate when signing a transaction or in settings section.

[mmv08]

@dasanra please take a look again
I changed the ADD_SAFE action to return the existing state and not modify it if the safe already exists. To solve it in a fundamental way, we would have to rethink how safe is loaded when you land on the safe page as there is clearly a concurrency problem between add/update safe actions

[ghost]

Travis automatic deployment:
https://pr1333--safereact.review.gnosisdev.com/app

[fernandomg]

nice!

[ghost]

Travis automatic deployment:
https://pr1333--safereact.review.gnosisdev.com/app