Revert strict null check refactor

[dasanra]

Revert "Tech debt 1265: Enable strictNullChecks TS compiler option (#1301)"

This reverts commit bfed967.

In order to organize better how we handle this bug I suggest to start reverting this PR and work calmly to find the related issues.

I already restored the original branch with a fix I also added to generateBatchRequests.
We can take it from here and not block all other PRs

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[Agupane]

Great idea thanks @dasanra !

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	97	0
Ignored	5	N/A

• Result: ✅ success

• Annotations: 97 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/components/Table/TableHead.tsx Line 22 - Argument 'property' should be typed.
• src/components/Table/TableHead.tsx Line 22 - Argument 'orderAttr' should be typed.
• src/components/Table/TableHead.tsx Line 22 - Missing return type on function.
• src/components/Table/TableHead.tsx Line 28 - Missing return type on function.
• src/logic/addressBook/utils/index.ts Line 14 - Missing return type on function.
• src/logic/addressBook/utils/index.ts Line 14 - Argument 'addressBook' should be typed.
• src/logic/addressBook/utils/index.ts Line 22 - Missing return type on function.
• src/logic/addressBook/utils/index.ts Line 22 - Argument 'addressBook' should be typed.
• src/logic/addressBook/utils/index.ts Line 24 - Missing return type on function.
• src/logic/addressBook/utils/index.ts Line 24 - Argument 'addressBook' should be typed.
• src/logic/addressBook/utils/index.ts Line 24 - Argument 'userAddress' should be typed.
• src/logic/currencyValues/store/middleware/index.ts Line 12 - Argument 'store' should be typed.
• src/logic/currencyValues/store/middleware/index.ts Line 12 - Argument 'next' should be typed.
• src/logic/currencyValues/store/middleware/index.ts Line 12 - Missing return type on function.
• src/logic/currencyValues/store/middleware/index.ts Line 12 - Argument 'action' should be typed.
• src/logic/currentSession/store/actions/loadCurrentSessionFromStorage.ts Line 5 - Missing return type on function.
• src/logic/currentSession/store/actions/loadCurrentSessionFromStorage.ts Line 5 - Argument 'dispatch' should be typed.
• src/logic/currentSession/utils/index.ts Line 5 - Missing return type on function.
• src/logic/currentSession/utils/index.ts Line 7 - Missing return type on function.
• src/logic/currentSession/utils/index.ts Line 7 - Argument 'currentSession' should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 27 - Object pattern argument should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 27 - Missing return type on function.
• src/logic/safe/store/actions/processTransaction.ts Line 28 - Argument 'dispatch' should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 29 - Argument 'getState' should be typed.
• src/logic/safe/store/actions/transactions/fetchTransactions/loadIncomingTransactions.ts Line 77 - Missing return type on function.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'store' should be typed.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'next' should be typed.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Missing return type on function.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'action' should be typed.
• src/logic/safe/transactions/awaitingTransactions.ts Line 5 - Missing return type on function.
• src/logic/safe/transactions/awaitingTransactions.ts Line 5 - Argument 'cancellationTxs' should be typed.
• src/logic/safe/transactions/offchainSigner/ethSigner.ts Line 7 - Object pattern argument should be typed.
• src/logic/safe/utils/safeStorage.ts Line 18 - Missing return type on function.
• src/logic/safe/utils/safeStorage.ts Line 18 - Argument 'safes' should be typed.
• src/logic/tokens/store/actions/fetchTokens.ts Line 46 - Missing return type on function.
• src/logic/tokens/store/actions/fetchTokens.ts Line 46 - Argument 'contractAddress' should be typed.
• src/logic/tokens/store/actions/fetchTokens.ts Line 46 - Argument 'methodHash' should be typed.
• src/logic/tokens/store/actions/fetchTokens.ts Line 94 - Missing return type on function.
• src/logic/tokens/store/actions/fetchTokens.ts Line 94 - Argument 'dispatch' should be typed.
• src/logic/tokens/store/actions/fetchTokens.ts Line 94 - Argument 'getState' should be typed.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 21 - Argument 'store' should be typed.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 21 - Argument 'next' should be typed.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 21 - Missing return type on function.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 21 - Argument 'action' should be typed.
• src/routes/load/components/DetailsForm/index.tsx Line 45 - Argument 'values' should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Object pattern argument should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Argument 'network' should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Missing return type on function.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Argument 'controls' should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Object pattern argument should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Missing return type on function.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Argument 'index' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Argument 'notRemovedOwners' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 39 - Argument 'values' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Object pattern argument should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Missing return type on function.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Argument 'controls' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 220 - Object pattern argument should be typed.
• src/routes/open/container/Open.tsx Line 48 - Missing return type on function.
• src/routes/open/container/Open.tsx Line 48 - Argument 'safeAddress' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Argument 'safeName' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Argument 'ownersNames' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Argument 'ownerAddresses' should be typed.
• src/routes/open/container/Open.tsx Line 56 - Missing return type on function.
• src/routes/open/container/Open.tsx Line 56 - Argument 'values' should be typed.
• src/routes/open/container/Open.tsx Line 56 - Argument 'userAccount' should be typed.
• src/routes/opening/index.tsx Line 105 - Missing return type on function.
• src/routes/opening/index.tsx Line 105 - Object pattern argument should be typed with a non-any type.
• src/routes/safe/components/Balances/SendModal/SafeInfo/index.tsx Line 7 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/ChooseTxType/index.tsx Line 63 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/ChooseTxType/index.tsx Line 63 - Object pattern argument should be typed.
• src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/EthValue/index.tsx Line 23 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/MethodsDropdown/index.tsx Line 27 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/Review/index.tsx Line 43 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Object pattern argument should be typed.
• src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.tsx Line 51 - Object pattern argument should be typed.
• src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/screens/ThresholdForm/style.ts Line 3 - Missing return type on function.
• src/routes/safe/components/Settings/RemoveSafeModal/style.ts Line 3 - Missing return type on function.
• src/routes/safe/components/Settings/ThresholdSettings/style.ts Line 3 - Missing return type on function.
• src/utils/clipboard.ts Line 1 - Missing return type on function.
• src/utils/clipboard.ts Line 1 - Argument 'text' should be typed.
• src/utils/intercom.ts Line 4 - Missing return type on function.
• src/utils/storage/signatures.ts Line 7 - Missing return type on function.
• src/utils/storage/signatures.ts Line 7 - Argument 'safeAddress' should be typed.
• src/utils/storage/signatures.ts Line 7 - Argument 'nonce' should be typed.
• src/utils/storage/signatures.ts Line 7 - Argument 'signature' should be typed.
• src/utils/storage/signatures.ts Line 22 - Missing return type on function.
• src/utils/storage/signatures.ts Line 22 - Argument 'safeAddress' should be typed.
• src/utils/storage/signatures.ts Line 22 - Argument 'nonce' should be typed.
• src/utils/storage/transactions.ts Line 7 - Missing return type on function.
• src/utils/storage/transactions.ts Line 7 - Argument 'safeAddress' should be typed.
• src/utils/storage/transactions.ts Line 7 - Argument 'nonce' should be typed.
• src/utils/storage/transactions.ts Line 7 - Argument 'subject' should be typed.
• src/utils/strings.ts Line 19 - Missing return type on function.

---

[warning] @typescript-eslint/no-non-null-assertion

Disallows non-null assertions using the ! postfix operator

• src/routes/safe/components/Transactions/TxsTable/TxType/index.tsx Line 74 - Forbidden non-null assertion.
• src/routes/safe/components/Transactions/TxsTable/TxType/index.tsx Line 74 - Forbidden non-null assertion.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1335--safereact.review.gnosisdev.com/app