Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) Tooltip equivalent balance may be zero#1337

Merged
dasanra merged 10 commits intodevelopmentfrom
feature/balance-tooltip
Sep 11, 2020
Merged

(Feature) Tooltip equivalent balance may be zero#1337
dasanra merged 10 commits intodevelopmentfrom
feature/balance-tooltip

Conversation

@matextrem
Copy link
Contributor

@matextrem matextrem commented Sep 9, 2020

Closes #1096

@matextrem matextrem added Enhancement ✨ Minor Improvement / changes to existing functionality Major Needs to be fixed for immediate next public release. labels Sep 9, 2020
@matextrem matextrem requested a review from mmv08 September 9, 2020 16:38
@matextrem matextrem self-assigned this Sep 9, 2020
@github-actions
Copy link

github-actions bot commented Sep 9, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@matextrem matextrem added Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped. and removed Major Needs to be fixed for immediate next public release. labels Sep 9, 2020
@github-actions
Copy link

github-actions bot commented Sep 9, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 9, 2020

Travis automatic deployment:
https://pr1337--safereact.review.gnosisdev.com/app

@lukasschor
Copy link
Contributor

lukasschor commented Sep 9, 2020 •
edited
Loading

image

The info icon should only be displayed if balance > 0 & value = 0

In the case of both balance and value = 0, it should not be shown.

(otherwise looks good)

@matextrem
Copy link
Contributor Author

matextrem commented Sep 9, 2020

Oh didn't know that. Let me fix it.

@lukasschor
Copy link
Contributor

lukasschor commented Sep 9, 2020

image

Yeah, could have been highlighted better in the ticket description

@pablofullana
Copy link

pablofullana commented Sep 9, 2020

Yeah, could have been highlighted better in the ticket description

😓

@ghost
Copy link

ghost commented Sep 9, 2020

Travis automatic deployment:
https://pr1337--safereact.review.gnosisdev.com/app

dasanra
dasanra suggested changes Sep 10, 2020
View reviewed changes
@ghost
Copy link

ghost commented Sep 10, 2020

Travis automatic deployment:
https://pr1337--safereact.review.gnosisdev.com/app

mmv08
mmv08 suggested changes Sep 10, 2020
View reviewed changes
@matextrem matextrem requested review from dasanra and mmv08 September 10, 2020 16:20
@ghost
Copy link

ghost commented Sep 10, 2020

Travis automatic deployment:
https://pr1337--safereact.review.gnosisdev.com/app

@lukasschor lukasschor changed the title Tooltip equivalent balance may be zero (Feature) Tooltip equivalent balance may be zero Sep 11, 2020
@matextrem matextrem requested review from fernandomg and removed request for mmv08 September 11, 2020 15:44
@dasanra dasanra merged commit 9ead8ef into development Sep 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2020
@dasanra dasanra deleted the feature/balance-tooltip branch September 11, 2020 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fernandomg fernandomg Awaiting requested review from fernandomg

2 more reviewers

@mmv08 mmv08 mmv08 approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matextrem matextrem

Labels

Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped. Enhancement ✨ Minor Improvement / changes to existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooltip stating why a USD equivalent balance may be zero

5 participants

@matextrem @lukasschor @pablofullana @mmv08 @dasanra