Feature: Send env info message on safe apps sdk initialization

[mmv08]

This PR:

• Is required for Allow to query transaction from safe-react via safeTxHash safe-global/safe-apps-sdk#29 to work, add ENV_INFO message sent on a handshake between the interface and an app
• fix onUserConfirm handler not being called if the transaction is signed with an off-chain signature
• Pass safeTxHash to offchain signer

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	11	0
Ignored	0	N/A

• Result: ✅ success

• Annotations: 11 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/logic/safe/store/actions/processTransaction.ts Line 26 - Object pattern argument should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 26 - Missing return type on function.
• src/logic/safe/store/actions/processTransaction.ts Line 27 - Argument 'dispatch' should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 28 - Argument 'getState' should be typed.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'store' should be typed.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'next' should be typed.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Missing return type on function.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'action' should be typed.
• src/logic/safe/transactions/offchainSigner/EIP712Signer.ts Line 62 - Missing return type on function.
• src/logic/safe/transactions/offchainSigner/EIP712Signer.ts Line 62 - Argument 'txArgs' should be typed.
• src/logic/safe/transactions/offchainSigner/index.ts Line 21 - Argument 'txArgs' should be typed.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1349--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1349--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1349--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1349--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1349--safereact.review.gnosisdev.com/app

[rmeissner]

It does not handle failure of signature generation (in that case we should send the rejected message to the safe app) -> has been started here: #1354

[mmv08]

@rmeissner what is a failure of signature generation? The modal thing you wrote in slack?

[rmeissner]

Yes, the comment in slack was related to the other PR but applies here too :) basically right now if the user rejects the signature it will not notify the safe apps sdk (as far as I understand the code it would throw https://github.com/gnosis/safe-react/pull/1349/files#diff-622f1ade90af2b81fb05085d0f4345bbR34 and then it would not notify the safe app ... but I might be wrong :P)

[ghost]

Travis automatic deployment:
https://pr1349--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1349--safereact.review.gnosisdev.com/app

Changes

[ghost]

Travis automatic deployment:
https://pr1349--safereact.review.gnosisdev.com/app