Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Add manual trigger to desktop app build#1356

Merged
mmv08 merged 6 commits intodevelopmentfrom
feature/add-manual-trigger-to-desktop-app-build
Sep 14, 2020
Merged

Add manual trigger to desktop app build#1356
mmv08 merged 6 commits intodevelopmentfrom
feature/add-manual-trigger-to-desktop-app-build

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Sep 14, 2020

This fix issue #1355

It also includes a dependency bump of electron dependencies to the latest compatible version. This upgrade includes a flag for a deprecated feature that will disappear on electron v11. We still have one dependency that crashes under this breaking change. We have to study how to handle this before v9 becomes out of maintenance. Currently v7 have been set as out of maintenance.

@dasanra dasanra self-assigned this Sep 14, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@mmv08
Copy link
Contributor

mmv08 commented Sep 14, 2020

How do we dispatch the action? Will we have an easy way to do that or will have to send a request to github API or something like that?

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Sep 14, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@dasanra
Copy link
Collaborator Author

dasanra commented Sep 14, 2020

How do we dispatch the action? Will we have an easy way to do that or will have to send a request to github API or something like that?

@mikheevm this is a relatively new feature on Github. Once the workflow_dispatch get to the default branch, in this case development we will be able to see in actions tab a button that will allow us to trigger this action manually in the desired branch. The workflow_dispatch event should also be in the github action file before being able to trigger it to the selected branch. This means once this change gets to development we will see the button but we won't be able to trigger a master build until this change also gets to master.

https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/

@ghost
Copy link

ghost commented Sep 14, 2020

Travis automatic deployment:
https://pr1356--safereact.review.gnosisdev.com/app

Comment on lines +35 to +41
- uses: actions/cache@v2
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ghost
Copy link

ghost commented Sep 14, 2020

Travis automatic deployment:
https://pr1356--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 14, 2020

Travis automatic deployment:
https://pr1356--safereact.review.gnosisdev.com/app

@mmv08 mmv08 merged commit 141b646 into development Sep 14, 2020
@mmv08 mmv08 deleted the feature/add-manual-trigger-to-desktop-app-build branch September 14, 2020 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants