Safe name - Character limit inconsistency #458

[dasanra]

Fix issue #458

It should now validate that Safe name and Owner name maxLength is 50. This is the same requirement that is necessary in settings when trying to change any of this names

This fix will also help with issue #188 , because the interface is able to handle names of 50 characters lenght

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	17	0
Ignored	0	N/A

• Result: ✅ success

• Annotations: 17 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/routes/load/components/DetailsForm/index.tsx Line 51 - Argument 'values' should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Object pattern argument should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Argument 'network' should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Missing return type on function.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Argument 'controls' should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Object pattern argument should be typed.
• src/routes/open/components/SafeNameForm/index.tsx Line 69 - Missing return type on function.
• src/routes/open/components/SafeNameForm/index.tsx Line 69 - Argument 'controls' should be typed.
• src/routes/open/components/SafeNameForm/index.tsx Line 69 - Object pattern argument should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 46 - Missing return type on function.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 46 - Argument 'index' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 46 - Argument 'notRemovedOwners' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 46 - Argument 'values' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 227 - Object pattern argument should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 227 - Missing return type on function.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 227 - Argument 'controls' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 227 - Object pattern argument should be typed.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1357--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1357--safereact.review.gnosisdev.com/app

[francovenica]

The ticket #188 seems to have been fixed before since the issue is no longer present, the table adjust just fine to different portview sizes

Limit of 50 characters for safe's name during safe creation. Checked
Limit of 50 characters for owner's name during safe creation. Checked
Limit of 50 characters for safe's name during safe loading. Checked
Limit of 50 characters for owner's name during safe loading. Issue 1
Limit of 50 characters for safe's name edition in the settings tab. Checked
Limit of 50 characters for owner's name edition in the settings tab. Checked

@dasanra
Issues:
1- When Changing the name of a owner during the "Load safe" process at first the "50 character limit" flickers instead of remaining there until you enter a name under 50 chars. Not critical since the validation works fine if you try to submit, but still it looks wonky
https://www.loom.com/share/64f5bf9ea503493cb84b9268a57cc3a5
In the video can bee seen how I set a 50 character name for the user, and as I keep adding character the error of "50 chars limit" flickers instead of remaining there. Is not until I click the submit button that the error stays there