Add WalletConnect safe-app

[nicosampler]

Closes #1363

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1364--safereact.review.gnosisdev.com/app

[tschubotz]

I think the app should be called "WalletConnect", not "Safe connect"

From the designs:

(https://projects.invisionapp.com/share/T4XF6KSQX7M#/screens/429167947_Apps_-Safe_Connect-_1272px)

[nicosampler]

Good catch, I will change it.

[tschubotz]

@nicosampler
Do you know of a Rinkeby dapp that I can use to test this? https://example.walletconnect.org somehow doesn't work for me, i.e. I cannot trigger a tx.

Also: When I connect with my Rinekby Metamask to https://app.uniswap.org, it works like a charm. But when I connect via WalletConnect to my RinkebySafe, it shows "Wrong network". Do you have any idea why that is? It's probably on the Uniswap side, but I was wondering if you have any idea :)

[nicosampler]

I'm using https://mintr.synthetix.io/

[tschubotz]

I'm using https://mintr.synthetix.io/

How do I get Rinkeby SNX?

[ghost]

Travis automatic deployment:
https://pr1364--safereact.review.gnosisdev.com/app

[nicosampler]

@tschubotz
use this contract address 0x3cA27cEEDA9A200f50C3Cf3802C6c60d43867977 in tx-builder and execute method mint, it will provide you with 200 snx.

After that, you can go to Mintr app and mint some sUSDC. Note that the UI in Mintr will get stuck in "awaiting for approval" but if you pay attention at the list in the left-bottom corner, you will see the balances are updated (sUDC) once you have signed the TX in the safe.

[tschubotz]

use this contract address 0x3cA27cEEDA9A200f50C3Cf3802C6c60d43867977 in tx-builder and execute method mint, it will provide you with 200 snx.

Hmm, this always fails for me, even with Metamask 🤔
https://rinkeby.etherscan.io/tx/0xe055d55339a78fe2680c6ab1f4b87dcbfcf2c2aee5e0ec3e15cc97775631c417

[nicosampler]

mmm, it worked just fine for me: https://safe-team.dev.gnosisdev.com/app/#/safes/0xEE63624cC4Dd2355B16b35eFaadF3F7450A9438B/transactions. Check nonce 11.

[nicosampler]

I can send you some tokens if you give me an address.

[tschubotz]

I can send you some tokens if you give me an address.

That would be great! Here's my RInkeby Safe: https://rinkeby.etherscan.io/address/0xae3c91c89153deac332ab7bbd167164978638c30

I'll try to figure out why the tx fails in the meantime.

EDIT: Figured it out, have SNX now :)

[nicosampler]

great, now you have 50 more =D. https://rinkeby.etherscan.io/tx/0xe6f18dae561b48e29481cfdb7f7cd4de547cfd44bfac455bdfd8b3aa32ca4db0

[tschubotz]

there are a couple of typos in the description

• In 3: "Paste" is missing the "e"
• In 5: "view" -> "via"
• In the link: "to user" -> "to use"

For reference here the link to the invision prototype with correct texts: https://projects.invisionapp.com/share/T4XF6KSQX7M#/screens/429167947_Apps_-Safe_Connect-_1272px

[nicosampler]

@tschubotz what was the problem with SNX? @francovenica is having the same issue

[nicosampler]

@tschubotz, @francovenica and I are having the same issue with Uniswap and Sablier. When we connect the safe with the dapp it shows "wrong network", I been debugging and we are passing the proper chainId for rinkeby = 4.
For Mintr it works fine so that makes me think that it's a problem with these dapps. I suggest to merge it and then test it on mainnet.

Typos will be fixed in safe-apps repo. This PR only adds the url for the safe-app.

[ghost]

Travis automatic deployment:
https://pr1364--safereact.review.gnosisdev.com/app

[dasanra]

@nicosampler I was having also that network error issue with Sablier. Didn't had time to do a further check

[nicosampler]

It's happening only on Rinkeby, on Mainnet works fine.
As Mintr works fine in both network I guess is something related with Sablier/Rinkeby.
I debugged the source code and we are sending the correct network.

[tschubotz]

This Rinkeby issue on e.g. Uniswap is happening for me also when I use Metamask mobile on Rinkeby with Uniswap.
So it seems to me like it's indeed an issue on the dapp's side.

Still, weird that Metamask extension works on Rinkeby with Uniswap. Would be interesting to know why that is. Here's the uniswap code if anyone wants to take a look: https://github.com/Uniswap/uniswap-interface/

[mmv08]

@tschubotz from the source code it seems like uniswap walletconnect's connector supports only mainnet:
https://github.com/Uniswap/uniswap-interface/blob/master/src/connectors/index.ts#L34

injected providers support multiple networks:
https://github.com/Uniswap/uniswap-interface/blob/master/src/connectors/index.ts#L30

[tschubotz]

@tschubotz from the source code it seems like uniswap walletconnect's connector supports only mainnet:
https://github.com/Uniswap/uniswap-interface/blob/master/src/connectors/index.ts#L34

injected providers support multiple networks:
https://github.com/Uniswap/uniswap-interface/blob/master/src/connectors/index.ts#L30

That explains it then, thanks for checking! :)

[ghost]

Travis automatic deployment:
https://pr1364--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1364--safereact.review.gnosisdev.com/app

[francovenica]

Tried again today in this PR adding the app once again
Tried in rinkeby with https://mintr.synthetix.io/ since it works with the rinkeby network

The connection to the app worked just fine
I tried to mint tokens, but at first the tx wasn't showing up in the safe to sign.
Tried again after a while and the tx showup on itself, so it got "stuck" in mintr for a while until it trigger again it seems.

Tried one more time and this time it worked right away, I was able to sign and get the tokens I minted:

It works fine, but since we cannot test every dapp out there with a WC then we have to keep an eye on user feedback.

[ghost]

Travis automatic deployment:
https://pr1364--safereact.review.gnosisdev.com/app