Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

ENS names not working properly#1372

Merged
dasanra merged 14 commits intodevelopmentfrom
fix/ens-names
Sep 21, 2020
Merged

ENS names not working properly#1372
dasanra merged 14 commits intodevelopmentfrom
fix/ens-names

Conversation

@matextrem
Copy link
Contributor

@matextrem matextrem commented Sep 17, 2020

closes #1238

@matextrem matextrem added Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release. labels Sep 17, 2020
@matextrem matextrem self-assigned this Sep 17, 2020
@github-actions
Copy link

github-actions bot commented Sep 17, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 17, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 17, 2020

Travis automatic deployment:
https://pr1372--safereact.review.gnosisdev.com/app

dasanra
dasanra suggested changes Sep 17, 2020
View reviewed changes
@ghost
Copy link

ghost commented Sep 17, 2020

Travis automatic deployment:
https://pr1372--safereact.review.gnosisdev.com/app

@matextrem matextrem requested a review from dasanra September 17, 2020 16:44
@ghost
Copy link

ghost commented Sep 17, 2020

Travis automatic deployment:
https://pr1372--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 18, 2020

Travis automatic deployment:
https://pr1372--safereact.review.gnosisdev.com/app

@dasanra
Copy link
Collaborator

dasanra commented Sep 21, 2020

If a random value is added having a valid ENS extension de full app crashes. Can you check it?

@ghost
Copy link

ghost commented Sep 21, 2020

Travis automatic deployment:
https://pr1372--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Sep 21, 2020

Travis automatic deployment:
https://pr1372--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 21, 2020

Travis automatic deployment:
https://pr1372--safereact.review.gnosisdev.com/app

@francovenica
Copy link
Contributor

francovenica commented Sep 21, 2020

The address now is displayed if the name is valid (along with the name)
The Etherescan icon now displays the correct address
The "Copy to clipboard" icon now copies the hash that belongs to the name, and not the name itself

Checked on the Send funds form, Send collectibles form, Contract interaction form where only Smart Contracts are allowed, even by ENS name.

image.png

Looks good to me

@francovenica francovenica self-requested a review September 21, 2020 14:10
@dasanra dasanra merged commit 46c5946 into development Sep 21, 2020
@dasanra dasanra deleted the fix/ens-names branch September 21, 2020 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fernandomg fernandomg Awaiting requested review from fernandomg

2 more reviewers

@francovenica francovenica francovenica approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matextrem matextrem

Labels

Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recipient fields - ENS names not working properly

3 participants

@matextrem @dasanra @francovenica