(Feature) #588 Use addressBook names when creating/loading safe by Agupane · Pull Request #1377 · 5afe/safe-react

Agupane · 2020-09-18T15:01:48Z

Closes #588

Description

Now both load safe owner's list and create safe owner's input will use the addressbook values
Also if the user updates the owner name on the addresses list and the owner name is on the addressbook, it will be updated too
Also fixes a bug: when the user loads the safe it will show 'LOADED_SAFE' as name, instead of the name of the safe

Restructure addressbook store type

…to 1246-addressbook-entries-removed

…to 801-address-book-refactor # Conflicts: # src/logic/addressBook/store/actions/addAddressBook.js # src/logic/addressBook/store/actions/addAddressBookEntry.js # src/logic/addressBook/store/actions/addOrUpdateAddressBookEntry.js # src/logic/addressBook/store/actions/loadAddressBookFromStorage.js # src/logic/addressBook/store/actions/removeAddressBookEntry.js # src/logic/addressBook/store/actions/updateAddressBookEntry.js # src/logic/addressBook/store/reducer/addressBook.ts # src/logic/addressBook/store/selectors/index.js # src/routes/safe/components/AddressBook/index.tsx # src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx # src/routes/safe/components/Settings/ManageOwners/EditOwnerModal/index.tsx # src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx # src/routes/safe/container/Hooks/useLoadSafe.jsx # src/routes/safe/container/index.jsx # src/routes/safe/store/middleware/safeStorage.js

Remove unused saveAndUpdateAddressBook action

Add types Removes unused addAddressBook action

Let the user remove owners users without adding them again each time the safe loads

…to 1246-addressbook-entries-removed # Conflicts: # src/logic/addressBook/store/selectors/index.ts # src/logic/addressBook/utils/index.ts # src/routes/safe/components/AddressBook/index.tsx

…to 1246-addressbook-entries-removed # Conflicts: # src/logic/addressBook/model/addressBook.ts # src/logic/addressBook/store/reducer/addressBook.ts # src/logic/addressBook/store/selectors/index.ts # src/logic/addressBook/utils/index.ts # src/routes/safe/components/AddressBook/CreateEditEntryModal/index.tsx # src/routes/safe/components/AddressBook/index.tsx # src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx # src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.tsx # src/routes/safe/components/Settings/ManageOwners/index.tsx # src/store/index.ts

…ons on addAddressBookEntry

…to 1246-addressbook-entries-removed

ghost · 2020-09-22T14:55:01Z

Travis automatic deployment:
https://pr1377--safereact.review.gnosisdev.com/app

ghost · 2020-09-22T15:27:51Z

Travis automatic deployment:
https://pr1377--safereact.review.gnosisdev.com/app

src/logic/addressBook/utils/__tests__/addressBookUtils.test.ts

src/routes/load/container/Load.tsx

ghost · 2020-09-23T12:21:26Z

Travis automatic deployment:
https://pr1377--safereact.review.gnosisdev.com/app

ghost · 2020-09-23T12:59:20Z

Travis automatic deployment:
https://pr1377--safereact.review.gnosisdev.com/app

…to 588-use-adbk-names

ghost · 2020-09-23T13:21:13Z

Travis automatic deployment:
https://pr1377--safereact.review.gnosisdev.com/app

ghost · 2020-09-23T13:36:00Z

Travis automatic deployment:
https://pr1377--safereact.review.gnosisdev.com/app

dasanra

Good Job!

ghost · 2020-09-23T16:06:52Z

Travis automatic deployment:
https://pr1377--safereact.review.gnosisdev.com/app

ghost · 2020-09-23T16:25:07Z

Travis automatic deployment:
https://pr1377--safereact.review.gnosisdev.com/app

francovenica · 2020-09-23T17:38:21Z

The issue of the "UNKNOWN" name for the first owner listed during the safe creation if that owner was not in the address book already was fixed. Is now "My wallet" again

Checked again:
Creating a safe takes the names from the address book of known addresses
Loading safe autocompletes names from the address book if the address are known
Editing the name during safe creation or loading will edit them in the address book and settings
Editing the names in the settings edits the names in the address book and viceversa
Edited the name in the address book and created/loaded a safe again

It looks good to me

…eact into 588-use-adbk-names

ghost · 2020-09-23T17:58:16Z

Travis automatic deployment:
https://pr1377--safereact.review.gnosisdev.com/app

Agupane added 30 commits August 26, 2020 11:24

Fix addressbook types

b02199b

Restructure addressbook store type

Add more safe types

aac0bbb

Merge branch 'development' of https://github.com/gnosis/safe-react in…

51d2263

…to 1246-addressbook-entries-removed

Fix imports

383f72b

Removes .toJS() usage

5f1ce43

Fix condition for saving addressBook

f7cdd5c

Types & remove send button from addressbook if user not an owner

15bf738

Merge branch 'development' of https://github.com/gnosis/safe-react in…

fd15391

…to 1246-addressbook-entries-removed

Merge branch 'development' of https://github.com/gnosis/safe-react in…

a74db59

…to 1246-addressbook-entries-removed

Add types for addressBook actions

62aec5b

Remove unused saveAndUpdateAddressBook action

Refactor addressBook: make it global and removes immutableJS

c1503bb

Add types Removes unused addAddressBook action

Remove todo

d1efe8c

Fix edit and remove entries style when user is not owner

7985638

Adds and updates safe name in addressBook

1065d8f

Adds checkIfOwnerWasDeletedFromAddressBook

2539623

Let the user remove owners users without adding them again each time the safe loads

Simplify loadAddressBookFromStorage

c0868f7

Merge branch 'development' of https://github.com/gnosis/safe-react in…

3a51659

…to 1246-addressbook-entries-removed # Conflicts: # src/logic/addressBook/store/selectors/index.ts # src/logic/addressBook/utils/index.ts # src/routes/safe/components/AddressBook/index.tsx

Fix compilation errors included in pr #1301

f220250

Merge branch 'development' of https://github.com/gnosis/safe-react in…

7da3232

…to 1246-addressbook-entries-removed # Conflicts: # src/logic/addressBook/store/selectors/index.ts # src/logic/addressBook/utils/index.ts # src/routes/safe/components/AddressBook/index.tsx

Uses sameAddress function

5061e5a

Add migration function for old stored address books

88d945e

Update tests

e42c272

Replaces shouldAvoidUpdatesNotifications with addAddressBookEntryOpti…

6d5809c

…ons on addAddressBookEntry

Update tests

51dc123

Unify return on getOwnersWithNameFromAddressBook

c082155

Merge branch 'development' of https://github.com/gnosis/safe-react in…

799779b

…to 1246-addressbook-entries-removed

Adds the addressbook names in safe load

4a7dc41

Reword shouldAvoidUpdatesNotifications

38d92a1

Add tests for checkIfEntryWasDeletedFromAddressBook

137ae7c

Agupane added 3 commits September 22, 2020 11:55

Fix saveAddressBook test

8090c8c

Fix fetchSafeTokens.test.ts

498048b

fix tests

bbeacf4

dasanra suggested changes Sep 22, 2020

View reviewed changes

Fix tests

0226e3b

Fix test description

25bfb53

Merge branch 'development' of https://github.com/gnosis/safe-react in…

6a07d7b

…to 588-use-adbk-names

Add update individually safe props in addOrUpdate

34daf83

Agupane added 2 commits September 23, 2020 12:29

Fix updating addressbook entries on safe load/create

cb25fe3

Fix always loading safe as LOADED SAFE instead of safe name

1bc7338

Agupane requested a review from dasanra September 23, 2020 15:46

dasanra approved these changes Sep 23, 2020

View reviewed changes

Merge branch 'development' into 588-use-adbk-names

b4d0b86

francovenica approved these changes Sep 23, 2020

View reviewed changes

Agupane added 2 commits September 23, 2020 14:42

Fix adding owner as UNKNOWN on addressBook when adding new owner

df67045

Merge branch '588-use-adbk-names' of https://github.com/gnosis/safe-r…

d17c37e

…eact into 588-use-adbk-names

dasanra merged commit 6f707a6 into development Sep 23, 2020

dasanra deleted the 588-use-adbk-names branch September 23, 2020 18:14

github-actions bot locked and limited conversation to collaborators Sep 23, 2020

Conversation

Agupane commented Sep 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

ghost commented Sep 22, 2020

Uh oh!

ghost commented Sep 22, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Sep 23, 2020

Uh oh!

ghost commented Sep 23, 2020

Uh oh!

ghost commented Sep 23, 2020

Uh oh!

ghost commented Sep 23, 2020

Uh oh!

dasanra left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Sep 23, 2020

Uh oh!

ghost commented Sep 23, 2020

Uh oh!

francovenica commented Sep 23, 2020

Uh oh!

ghost commented Sep 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Agupane commented Sep 18, 2020 •

edited

Loading