Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Update travis script to execute tests#1382

Merged
dasanra merged 6 commits intodevelopmentfrom
feature/add-test-travis
Sep 24, 2020
Merged

Update travis script to execute tests#1382
dasanra merged 6 commits intodevelopmentfrom
feature/add-test-travis

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Sep 22, 2020

Update travis file so test failures are notified.
Clean some unused configuration

Also upgrade some dependencies with minor changes

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 22, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 2 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 22, 2020

Travis automatic deployment:
https://pr1382--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Sep 22, 2020

Travis automatic deployment:
https://pr1382--safereact.review.gnosisdev.com/app

@dasanra dasanra marked this pull request as ready for review September 22, 2020 17:21
@ghost
Copy link

ghost commented Sep 24, 2020

Travis automatic deployment:
https://pr1382--safereact.review.gnosisdev.com/app

@dasanra dasanra self-assigned this Sep 24, 2020
- yarn prettier:check
- yarn test:coverage
- yarn build
#- bash ./config/travis/build.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this file, seems that is not used anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I left it there for convenience until I confirm that production deployment is successful. Can create a ticket to remember about it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, it's ok for me :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agupane Agupane self-requested a review September 24, 2020 14:01
@dasanra dasanra merged commit 171b6d9 into development Sep 24, 2020
@dasanra dasanra deleted the feature/add-test-travis branch September 24, 2020 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants