(Fix) Recipient address used as name as well#1387
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
The address issue looks good to me, but the app is crashing on me When I tried to enter to https://pr1387--safereact.review.gnosisdev.com/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/ after it crashed in the settings EDIT: that second crash, trying to enter to the base URL happens also in the dev env. I have to enter into the /balances to not crash |
|
@francovenica you shouldn't be able to navigate to |
|
If it should not be possible then it should default to /balances url I think, better than a crash :D I can make a ticket for that EDIT: created a ticket for it: #1388 |
This PR closes #1386, by preventing the use of the eth address as
name. And by extracting the contract information from the Address Book if it exist.Note: despite this fixes the issue. I think we should review the whole
AddressBookInputcomponent, as its growing big and hard to maintain.