Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) Recipient address used as name as well#1387

Merged
dasanra merged 5 commits intodevelopmentfrom
fix/#1386-address-as-name
Sep 22, 2020
Merged

(Fix) Recipient address used as name as well#1387
dasanra merged 5 commits intodevelopmentfrom
fix/#1386-address-as-name

Conversation

@fernandomg
Copy link
Contributor

This PR closes #1386, by preventing the use of the eth address as name. And by extracting the contract information from the Address Book if it exist.

Note: despite this fixes the issue. I think we should review the whole AddressBookInput component, as its growing big and hard to maintain.

@fernandomg fernandomg added the Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped. label Sep 22, 2020
@fernandomg fernandomg self-assigned this Sep 22, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 22, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 22, 2020

Travis automatic deployment:
https://pr1387--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 22, 2020

Travis automatic deployment:
https://pr1387--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 22, 2020

Travis automatic deployment:
https://pr1387--safereact.review.gnosisdev.com/app

Copy link
Contributor

@matextrem matextrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost
Copy link

ghost commented Sep 22, 2020

Travis automatic deployment:
https://pr1387--safereact.review.gnosisdev.com/app

@francovenica
Copy link
Contributor

francovenica commented Sep 22, 2020

The address issue looks good to me, but the app is crashing on me
When I enter into the settings
image.png

When I tried to enter to https://pr1387--safereact.review.gnosisdev.com/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/ after it crashed in the settings
image.png

EDIT: that second crash, trying to enter to the base URL happens also in the dev env. I have to enter into the /balances to not crash

@dasanra
Copy link
Collaborator

dasanra commented Sep 22, 2020

@francovenica you shouldn't be able to navigate to safes/safeAddress/. At least no without doing it by hand. We should add another ticket for that

@francovenica
Copy link
Contributor

francovenica commented Sep 22, 2020

If it should not be possible then it should default to /balances url I think, better than a crash :D

I can make a ticket for that

EDIT: created a ticket for it: #1388

@dasanra dasanra merged commit e946879 into development Sep 22, 2020
@dasanra dasanra deleted the fix/#1386-address-as-name branch September 22, 2020 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recipient address as name

4 participants